From owner-svn-ports-all@FreeBSD.ORG  Thu Jun 11 06:17:17 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org
 [IPv6:2001:1900:2254:206a::19:2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F3549E18;
 Thu, 11 Jun 2015 06:17:16 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx2.freebsd.org (Postfix) with ESMTP id 553181EA1;
 Thu, 11 Jun 2015 06:17:16 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Message-ID: <557927EC.1060303@FreeBSD.org>
Date: Thu, 11 Jun 2015 02:17:16 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: koobs@FreeBSD.org, ports-committers@freebsd.org, 
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r389121 - head/archivers/py-lz4
References: <201506101814.t5AIESmI078385@svn.freebsd.org>
 <5578FCAD.6010201@FreeBSD.org>
In-Reply-To: <5578FCAD.6010201@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jun 2015 06:17:17 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 06/10/2015 23:12, Kubilay Kocak wrote:
> On 11/06/2015 4:14 AM, Jung-uk Kim wrote:
>> Author: jkim Date: Wed Jun 10 18:14:28 2015 New Revision: 389121 
>> URL: https://svnweb.freebsd.org/changeset/ports/389121
>> 
>> Log: Fix build dependency.
>> 
>> Modified: head/archivers/py-lz4/Makefile
>> 
>> Modified: head/archivers/py-lz4/Makefile 
>> ==============================================================================
>>
>> 
- --- head/archivers/py-lz4/Makefile	Wed Jun 10 18:12:35 2015	(r389120)
>> +++ head/archivers/py-lz4/Makefile	Wed Jun 10 18:14:28 2015
>> (r389121) @@ -11,6 +11,8 @@ COMMENT=	Python binding for the LZ4
>> comp
>> 
>> LICENSE=	BSD3CLAUSE
>> 
>> +BUILD_DEPENDS=
>> ${PYTHON_SITELIBDIR}/nose/__init__.py:${PORTSDIR}/devel/py-nose 
>> + USE_PYTHON=	autoplist distutils USES=		python
>> 
>> 
> 
> It's *very* likely setup_requires in setup.py adding a build
> dependency on nose [1] is a typo, and supposed to be tests_require
> 
> I would recommend patching setup.py to say:
> 
> setup_requires=["nose>=1.0"],

Done (r389157).

https://svnweb.freebsd.org/changeset/ports/389157

> And submitting the patch upstream in a PR.
> 
> [1] https://github.com/steeve/python-lz4/blob/master/setup.py#L34

There was one already and I just added a comment.

https://github.com/steeve/python-lz4/pull/35#issuecomment-110997473

Thanks!

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVeSfrAAoJEHyflib82/FGZJUH/jz0QdXeEeBHDZMvhprUzREM
2x65DYsl4Ql4JQfwa7WSeDseucD2ohhi8R1HP7ttgXtusU8qLdqiUdzRP7Qzse16
qKqtF1HP851kKmoSVRdFB8+hvsw5eHgIkpZfDOlkRrVQGsbz/Tn0gM7zUR/7DBZs
RtBp/XPL7w8AKM6+8Q0VKIRGxsP+6JSwMTNtzyrehaJ4eFbFva8ejc+WF8TCfTMJ
3rGIMpA8Hoc2Iq5oFtj5r8Bcm513YBnkwqAbikui5JyOlVy7xCR5D4mXQu7i2EId
zFNJydj44w7d62vicFwOmgglY8rywDMuYW+k1IRwTCnNLexNCxVrLxjJ7Mc1DUA=
=4HCL
-----END PGP SIGNATURE-----