From owner-svn-src-all@FreeBSD.ORG Sat Jun 13 01:13:43 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C4252928; Sat, 13 Jun 2015 01:13:43 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8CA3A76A; Sat, 13 Jun 2015 01:13:43 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by qkhq76 with SMTP id q76so24717830qkh.2; Fri, 12 Jun 2015 18:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=TPQnO2/ycX68uj+Yzs5vQk3jkBberemB4Ny3pftHbBY=; b=hB0XgcubeOUaqzsVO/82OXF+bxINLBpCbgCIVGV2QCYukg9vGi4JRpP6HjaQc0lY52 MvFTO0GPyb0VbLbAH2BfLy+FY5SbtfIjaXHtseI+ofyohSv+7b52fL2bnC4/pZ9t5DSS DS1wr+FyP5TFM1N76IEbxx2151Br02vkboE+5pjEIrHiEzRq5d2cJne74sGeTqP24HSz lIi66R8PO9qY1QqpGuBXiDXMzAU5Z9H/Z1seI5LtfTKI0FviYizHNfoC4FPIgt/qEAxH 0hOwzsoBjnA2zGVscvaP/qV5+GrmAqWIhkfP01TWmgy1Omrfu0rHBhoKgXrLnNXF6+5N 9W6Q== X-Received: by 10.55.19.99 with SMTP id d96mr8984929qkh.71.1434158022569; Fri, 12 Jun 2015 18:13:42 -0700 (PDT) Received: from kan ([2601:18f:0:1570:226:18ff:fe00:232e]) by mx.google.com with ESMTPSA id b191sm2452376qka.14.2015.06.12.18.13.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jun 2015 18:13:42 -0700 (PDT) Date: Fri, 12 Jun 2015 21:13:35 -0400 From: Alexander Kabaev To: Marcel Moolenaar Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284198 - head/bin/ls Message-ID: <20150612211335.2d522cef@kan> In-Reply-To: <20150612204309.11dd3391@kan> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/UbDxBEjN6nq2tucYQ3BhEDR"; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 01:13:44 -0000 --Sig_/UbDxBEjN6nq2tucYQ3BhEDR Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 12 Jun 2015 20:43:09 -0400 Alexander Kabaev wrote: > On Wed, 10 Jun 2015 01:27:39 +0000 (UTC) > Marcel Moolenaar wrote: >=20 > > Author: marcel > > Date: Wed Jun 10 01:27:38 2015 > > New Revision: 284198 > > URL: https://svnweb.freebsd.org/changeset/base/284198 > >=20 > > Log: > > Convert ls(1) to use libxo(3). > > =20 > > Obtained from: Phil Shafer > > Sponsored by: Juniper Networks, Inc. > >=20 > >=20 > This broke all code that pipes output of the ls command to pipeline, > such as 'ls | wc -l'. ls never exits and never output anything. Is > there any purpose to libxo other than breaking stuff, which it > achieves so splendidly? >=20 Just to clarify, this happens because libxo cannot display file names in encodings current locate cannot handle. xo_format_string_direct function then spins indefinitely trying to call xo_failure(xop, "invalid mbs char: %02hhx", *cp) over and over, which, of course, produces nothing and does not advance the cp pointer either, resulting in apparent ls hang. --=20 Alexander Kabaev --Sig_/UbDxBEjN6nq2tucYQ3BhEDR Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJVe4O/XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+x48P/2HUQs/T5vIrCJNeybV7N3ub XHN1/Q9W2iQvOL2JbST9VZOva/D1Xlzm+Xl4RE/q5IbxyKcZOZrphY98QFEL7VGN WM9FydxBKqqKpo+bpl2/g1piHtIbMMQajAGV/l931bfvKu80Rmwes1z8gjyrmKeA btvYZldHpZFE1Z283KJP4ubhuobLWirV+fLY1mzcMzQ9ZtNHfSOII9oicbMcb/K1 pH1LmzlaLFwPq8VYpd+spKRyKDPsnM0An2xaou4PRowFkG/ibSVbZjScVbHp0eml c7qWFKe26bTNqJnZ+Qz4Ca9JYTb7yC+FRpwMEo0YG68tgDMZ9si+Pl+8LHmCjTtG LHQ1GxAuYVF/8aawJNM/d4zrQV7RrdI1aOxjZuNyS9JjOlFnsNDYNNDXlD/4HlMV bOhVA1KV0T45no9pukgyQKJZh2KNYjwgKnA+KNf5xobkOV5n1wkOUPRZBzD/zQod vnqaKWHRoQWtO+Gg08yxtfSU2zsFNBIWoODPCA9EbmIaMDFjS55NYGNu/on4Atzp ovVNBmg1i7fnY22ZSnR4cQcagjTvQZp/JNMipGtn4ekNInO8Aw0SEjQgoiiCMDR2 u7DwOtiJjRxg3Tr1kuSfCE+BjaSWKQ2N+w6d6MjEF3TVNUenABU83rKECEE4gGY7 dcFUDQBMchrTOCR/8Yjc =lIGd -----END PGP SIGNATURE----- --Sig_/UbDxBEjN6nq2tucYQ3BhEDR--