From owner-freebsd-rc@FreeBSD.ORG Thu Sep 6 22:10:41 2012 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6387D1065677; Thu, 6 Sep 2012 22:10:41 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from onyx.glenbarber.us (onyx.glenbarber.us [IPv6:2607:fc50:1000:c200::face]) by mx1.freebsd.org (Postfix) with ESMTP id 3623E8FC15; Thu, 6 Sep 2012 22:10:41 +0000 (UTC) Received: from glenbarber.us (unknown [IPv6:2001:470:8:1205:2:2:0:100]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: gjb) by onyx.glenbarber.us (Postfix) with ESMTPSA id 1ED4F23F645; Thu, 6 Sep 2012 18:10:39 -0400 (EDT) Date: Thu, 6 Sep 2012 18:10:36 -0400 From: Glen Barber To: Doug Barton Message-ID: <20120906221036.GF1332@glenbarber.us> References: <20120906195706.GD1332@glenbarber.us> <50491DB2.1020702@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WRT3RXLOp/bBMgTI" Content-Disposition: inline In-Reply-To: <50491DB2.1020702@FreeBSD.org> X-Operating-System: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: rc@FreeBSD.org Subject: Re: [PATCH] Allow use of program path overrides X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2012 22:10:41 -0000 --WRT3RXLOp/bBMgTI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 06, 2012 at 03:03:30PM -0700, Doug Barton wrote: > On 9/6/2012 12:57 PM, Glen Barber wrote: > > Hi, > >=20 > > Many rc(8) scripts have corresponding 'foo_program=3D"/path/to/foo"'=20 > > entries in etc/defaults/rc.conf . >=20 > These are usually only added for things that might get overridden by > something from ports. >=20 I can think of valid reasons one might want to do this otherwise. > > However, some are missing the functionality to override $command=20 > > correctly. >=20 > rc.subr should already do that. Have you tested it? >=20 Yes. See the previous thread on -rc@ . > > The attached patch: > >=20 > > - Adds missing "${name}_program=3D/path/to/${name}" entries to=20 > > defaults/rc.conf >=20 > Please don't do that. :) >=20 > > - Adds missing functionality of setting=20 > > "command=3D${foo_program:-/path/to/foo}" in corresponding rc(8)=20 > > scripts. >=20 > Please don't do this either. :) >=20 Ok. I'll bite. "Why not?" Glen --WRT3RXLOp/bBMgTI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJQSR9cAAoJEFJPDDeguUajYnYH/1hXxZgSwmzH1+gVAjtAxtuA +3gtnfJqH5hCiLo254nBk5fNqBh0qrnZDxLPbKyp4y8yD701G/MHZ6DD7yYCUHJ2 P5o6cGEyk3S97nDCUa+e/QXvlUh4WPsDXUVK6EreKwdghSHDn4xQRwU97YbLFxql H4ejWeTK4S8/ytadP6U5H+mm3yknAgWoYqFXEMkomOrGgwKU1AKOGzLjT0oZThis HCNdzejB+EQuPVpQSLuZOtBQAAgFMTll2m/bFBgsFauVjYNxNN7v+H++kidIic8u lJE+ZnKHkswQOSkzzuf1p48g5mX5zhp5Sn/S+/2YEYOrDPaDubGznGRzOZDmA7o= =smB5 -----END PGP SIGNATURE----- --WRT3RXLOp/bBMgTI--