Date: Sun, 14 Mar 2010 08:04:44 GMT From: "Earl R. Lapus" <earl.lapus@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/144730: [ping6] lacks call to freeaddrinfo() Message-ID: <201003140804.o2E84iIo094480@www.freebsd.org> Resent-Message-ID: <201003140810.o2E8A2hT095576@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 144730 >Category: misc >Synopsis: [ping6] lacks call to freeaddrinfo() >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Mar 14 08:10:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Earl R. Lapus >Release: FreeBSD 8.0 >Organization: >Environment: FreeBSD syutsyut.cebu.infoweapons.com 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Tue Dec 15 12:44:45 PHT 2009 root@syutsyut.cebu.infoweapons.com:/usr/obj/usr/src/sys/SYUTSYUT i386 >Description: One particular call to getaddrinfo() in ping6.c didn't have a freeaddrinfo() pair. All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? >How-To-Repeat: >Fix: Patch attached with submission follows: diff -ruN ../src/sbin/ping6/ping6.c ../src.mod/sbin/ping6/ping6.c --- ../src/sbin/ping6/ping6.c 2009-10-25 09:10:29.000000000 +0800 +++ ../src.mod/sbin/ping6/ping6.c 2010-03-13 19:46:45.000000000 +0800 @@ -635,6 +635,8 @@ res->ai_protocol)) < 0) err(1, "socket"); + freeaddrinfo(res); + /* set the source address if specified. */ if ((options & F_SRCADDR) && bind(s, (struct sockaddr *)&src, srclen) != 0) { >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003140804.o2E84iIo094480>