From owner-freebsd-bugs@FreeBSD.ORG Sun Mar 14 08:10:02 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1F46106566B for ; Sun, 14 Mar 2010 08:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B4D7F8FC1A for ; Sun, 14 Mar 2010 08:10:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2E8A2fW095577 for ; Sun, 14 Mar 2010 08:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2E8A2hT095576; Sun, 14 Mar 2010 08:10:02 GMT (envelope-from gnats) Resent-Date: Sun, 14 Mar 2010 08:10:02 GMT Resent-Message-Id: <201003140810.o2E8A2hT095576@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Earl R. Lapus" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45F131065688 for ; Sun, 14 Mar 2010 08:04:45 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 2C3E48FC27 for ; Sun, 14 Mar 2010 08:04:45 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2E84ihV094481 for ; Sun, 14 Mar 2010 08:04:44 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o2E84iIo094480; Sun, 14 Mar 2010 08:04:44 GMT (envelope-from nobody) Message-Id: <201003140804.o2E84iIo094480@www.freebsd.org> Date: Sun, 14 Mar 2010 08:04:44 GMT From: "Earl R. Lapus" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/144730: [ping6] lacks call to freeaddrinfo() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 08:10:03 -0000 >Number: 144730 >Category: misc >Synopsis: [ping6] lacks call to freeaddrinfo() >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Mar 14 08:10:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Earl R. Lapus >Release: FreeBSD 8.0 >Organization: >Environment: FreeBSD syutsyut.cebu.infoweapons.com 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Tue Dec 15 12:44:45 PHT 2009 root@syutsyut.cebu.infoweapons.com:/usr/obj/usr/src/sys/SYUTSYUT i386 >Description: One particular call to getaddrinfo() in ping6.c didn't have a freeaddrinfo() pair. All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? >How-To-Repeat: >Fix: Patch attached with submission follows: diff -ruN ../src/sbin/ping6/ping6.c ../src.mod/sbin/ping6/ping6.c --- ../src/sbin/ping6/ping6.c 2009-10-25 09:10:29.000000000 +0800 +++ ../src.mod/sbin/ping6/ping6.c 2010-03-13 19:46:45.000000000 +0800 @@ -635,6 +635,8 @@ res->ai_protocol)) < 0) err(1, "socket"); + freeaddrinfo(res); + /* set the source address if specified. */ if ((options & F_SRCADDR) && bind(s, (struct sockaddr *)&src, srclen) != 0) { >Release-Note: >Audit-Trail: >Unformatted: