From owner-cvs-src@FreeBSD.ORG Wed Feb 21 18:27:04 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 98DDE16D780; Wed, 21 Feb 2007 18:27:04 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.freebsd.org (Postfix) with ESMTP id 7BD5E13C474; Wed, 21 Feb 2007 18:27:04 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id l1LIR2bJ091787; Wed, 21 Feb 2007 10:27:02 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id l1LIR24u091786; Wed, 21 Feb 2007 10:27:02 -0800 (PST) (envelope-from rizzo) Date: Wed, 21 Feb 2007 10:27:02 -0800 From: Luigi Rizzo To: Andrew Gallatin Message-ID: <20070221102702.B91427@xorpc.icir.org> References: <200702151721.l1FHLWno019525@repoman.freebsd.org> <20070221121302.A20229@grasshopper.cs.duke.edu> <20070221092332.A90766@xorpc.icir.org> <17884.34420.308021.423716@grasshopper.cs.duke.edu> <20070221101005.A91427@xorpc.icir.org> <17884.36324.991314.70617@grasshopper.cs.duke.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <17884.36324.991314.70617@grasshopper.cs.duke.edu>; from gallatin@cs.duke.edu on Wed, Feb 21, 2007 at 01:22:28PM -0500 Cc: cvs-src@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/arm/xscale/ixp425 ixp425_npe.c src/sys/dev/ipw if_ipw.c if_ipwvar.h src/sys/dev/isp isp_freebsd.h src/sys/dev/iwi if_iwi.c if_iwivar.h src/sys/dev/mxge if_mxge.c src/sys/kern subr_firmware.c src/sys/sys firmware.h src/sys/tools fw_stub.awk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2007 18:27:04 -0000 On Wed, Feb 21, 2007 at 01:22:28PM -0500, Andrew Gallatin wrote: > > Luigi Rizzo writes: ,,, > > i am not sure i follow you here... > > Of course when you drop the lock you risk that the underlying > > data structure is manipulated (or in the worst case freed), > > but usually you can avoid this with something like > > > > > > sc->flags |= LEAVE_ME_ALONE > > UNLOCK > > Sorry, I hadn't noticed that iwi set a flag like that. I was not everywhere. i am sure that there are parts that are not protected. > I just think it would be safer, and less hacky to be allowed to hold > a driver mutex while potentially sleeping in the firmware code (and in i am no expert here, but in some sense, the mutex argument to msleep is there exactly for that reason. Maybe the problem is that sometimes you need more than one mutex ? In any case i think we should relabel the thread or potentially interested people will miss the content being misled by the subject! cheers luigi