Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Mar 2004 00:10:38 -0800
From:      Kris Kennaway <kris@obsecurity.org>
To:        Joe Marcus Clarke <marcus@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/www/mplayer-plugin Makefile
Message-ID:  <20040306081037.GA27564@xor.obsecurity.org>
In-Reply-To: <200403060733.i267XKd3044611@repoman.freebsd.org>
References:  <200403060733.i267XKd3044611@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote:
> marcus      2004/03/05 23:33:20 PST
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     www/mplayer-plugin   Makefile=20
>   Log:
>   Add firefox support via WITH_MOZILLA=3Dfirefox.  Note: this only works =
for
>   mplayer-plugin.  Setting WITH_MOZILLA=3Dfirefox will not work with the
>   galeon ports.

Shouldn't this be WITH_FIREFOX=3Dyes or similar?  Most WITH_ and
WITHOUT_ variables do not care about the value, and giving them
special values makes it difficult to use with configuration tools like
'make config'.

Kris

--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFASYd9Wry0BWjoQKURAqBNAJ47VciSAN6oNG7r2W3kFdHAHAq56wCfZ0G6
Vd/yJiCM1bkX+GXWnd903YM=
=fYJk
-----END PGP SIGNATURE-----

--C7zPtVaVf+AK4Oqc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040306081037.GA27564>