From owner-freebsd-current Tue Nov 23 15:24: 1 1999 Delivered-To: freebsd-current@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 6E62715458; Tue, 23 Nov 1999 15:22:30 -0800 (PST) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost [127.0.0.1]) by green.dyndns.org (8.9.3/8.9.3) with ESMTP id HAA24337; Tue, 23 Nov 1999 07:23:30 -0500 (EST) (envelope-from green@FreeBSD.org) Date: Tue, 23 Nov 1999 07:23:30 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Peter Wemm Cc: Christopher Masto , "Daniel O'Connor" , Steve Kargl , current@FreeBSD.org, Jean-Marc Zucconi , "Alexander N. Kabaev" Subject: Re: Netscape and -current In-Reply-To: <19991123061312.248461C6D@overcee.netplex.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 23 Nov 1999, Peter Wemm wrote: > Brian Fundakowski Feldman wrote: > > Forget anything I said about KAME being the strong possibility :) As > > soon as peter noted what commit it could have to do with, I figured > > it out and fixed it; after testing, I committed it. Be happy :) > > Your fix suffers from exactly the same problem.. Suppose down the track > that ucontext_t becomes smaller than 'struct sigocontext' ? You're then > failing what would have worked. The check against sizeof osigcontext should > not be fatal. That will not happen, though. Your proposal suffers from a very similar problem. Okay, let's assume that ucontext_t is _smaller_ than a struct osigcontext. If it fails the "osigcontext size test", it won't go to osigreturn, fine. BUT, it continues on, and is taken as a valid ucontext_t instead of an EINVAL osigcontext. Do you see where the problem is with this approach? Since the revision I committed went under an assumption that's alway going to be true, and even if it weren't, it would be updated to match the world anyway, I don't see the problem. > > Cheers, > -Peter > -- > Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > > -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message