From owner-cvs-all@FreeBSD.ORG  Sat Mar  6 00:17:54 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D47E016A4CE; Sat,  6 Mar 2004 00:17:54 -0800 (PST)
Received: from creme-brulee.marcuscom.com
	(rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 78E8143D31; Sat,  6 Mar 2004 00:17:54 -0800 (PST)
	(envelope-from marcus@FreeBSD.org)
Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4])
	i268HMrW059632;	Sat, 6 Mar 2004 03:17:22 -0500 (EST)
	(envelope-from marcus@FreeBSD.org)
From: Joe Marcus Clarke <marcus@FreeBSD.org>
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: <20040306081037.GA27564@xor.obsecurity.org>
References: <200403060733.i267XKd3044611@repoman.freebsd.org>
	 <20040306081037.GA27564@xor.obsecurity.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-5QPB1NDUvpFYDpXwMKJ1"
Organization: FreeBSD, Inc.
Message-Id: <1078561060.30101.3.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 06 Mar 2004 03:17:40 -0500
X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham 
	version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on 
	creme-brulee.marcuscom.com
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/mplayer-plugin Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Mar 2004 08:17:55 -0000


--=-5QPB1NDUvpFYDpXwMKJ1
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 2004-03-06 at 03:10, Kris Kennaway wrote:
> On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote:
> > marcus      2004/03/05 23:33:20 PST
> >=20
> >   FreeBSD ports repository
> >=20
> >   Modified files:
> >     www/mplayer-plugin   Makefile=20
> >   Log:
> >   Add firefox support via WITH_MOZILLA=3Dfirefox.  Note: this only work=
s for
> >   mplayer-plugin.  Setting WITH_MOZILLA=3Dfirefox will not work with th=
e
> >   galeon ports.
>=20
> Shouldn't this be WITH_FIREFOX=3Dyes or similar?  Most WITH_ and
> WITHOUT_ variables do not care about the value, and giving them
> special values makes it difficult to use with configuration tools like
> 'make config'.

This was done for scaling purposes in the original Mozilla-based ports
(galeon, galeon2, epiphany).  This way, one can specify the mozilla they
want to use (be it mozilla, mozilla-devel, and one point mozilla-vendor,
and now firefox).  It was easier than defining a large number of macros
then deciding on precedence.

Joe

>=20
> Kris
--=20
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

--=-5QPB1NDUvpFYDpXwMKJ1
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQBASYkkb2iPiv4Uz4cRAoZOAJ4kKTkoYhQUaib10xvt4GhONeV6qwCfRo7v
qj8mdOhz0ZBxUtqzzD0pHXY=
=DuIM
-----END PGP SIGNATURE-----

--=-5QPB1NDUvpFYDpXwMKJ1--