From owner-svn-src-all@freebsd.org Mon Sep 23 20:14:04 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 47D6EFE813 for ; Mon, 23 Sep 2019 20:14:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46cbBM33T8z4SP0 for ; Mon, 23 Sep 2019 20:14:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82d.google.com with SMTP id n7so18756333qtb.6 for ; Mon, 23 Sep 2019 13:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ulGasXaI9v/TNxmgKSreGJ2SNeC0XCJM+13FUH6BOXQ=; b=VEXrvE+QPfgn1xWK4TdcGMxNAO/YqDENlosUqDTBydLYBX0Sx/hndhKCx5AZ/ZmdYb g4fmPhsKWKAChv18ovdtzkRsV/n406P0o2WUhy62uVOba3ZI4T89zSDnVKp9LYcAqatr qPjv5A+ar0a6Nx44xlFmKUfs98sjhFpVE4spGTJP0UXuWHYWxqYS5LITBIg2jxkZCOV4 UPVmNCDNhuWtjS6OtpCTaF3HVVmxbEIIy+PVplwSBTbEqJXGhnnaNpQ2iNay6Lgqo/cG SDi9dQ1PMCPc2NBfLDk7wtItT47Ye9wYSgg8zJ63E33gum7IunDSuNhUt7P+zrEtWhlV jGWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ulGasXaI9v/TNxmgKSreGJ2SNeC0XCJM+13FUH6BOXQ=; b=ROTQqv8U7br4ugtLEfEXgch4X8s89O2C1gpp/dyMYWVJO7iTdAit9euCzLi6bL2w2Y rqruQMLKrAydthPwnHpnMyuSi0yM6Pvw20CgxsRwnWMGrWLhhcdXY4i4eLE33vFpPOhp bsG9U+QnkT2uShkvRY1ZOgNO9clZrUpMi9ipfmsJOJEQnoQg87Sc6+6auaYp75beWskK lzo9lWfgTSJ0YnKEGxrdsqm79W1eTMppyelQPslyTKZWdIkNYpHY5BjIYvSyJWUGd3At AGcj2YAcY/87zscysu8eBvUygLLJtl8Gv7doHTuKT2p35p0odfJ9EROfgtuyZ0soCgnC /GIQ== X-Gm-Message-State: APjAAAX8Ujq5gMC/2jy0sAjhXEXC6fBhrXp+W/KzXWh5kZv1XsABHTYE Y2Zuv3sT3LWOqbRxlB1D3+W40fNuiW9BSNJpDVoXFA== X-Google-Smtp-Source: APXvYqyUB78Clt/IcIfODGAS5mJYkA/d6OGiW8qi4Y2IuUiVreZVD/wvwc6HdDuu6/TaBMMc6sP5i3lR1zbzpY50iLI= X-Received: by 2002:ad4:52cc:: with SMTP id p12mr976002qvs.236.1569269642091; Mon, 23 Sep 2019 13:14:02 -0700 (PDT) MIME-Version: 1.0 References: <201909231414.x8NEEh9e040728@repo.freebsd.org> <20190923190629.GD15061@raichu> In-Reply-To: <20190923190629.GD15061@raichu> From: Warner Losh Date: Mon, 23 Sep 2019 22:13:14 +0200 Message-ID: Subject: Re: svn commit: r352623 - in head/sys: amd64/amd64 kern To: Mark Johnston Cc: "Conrad E. Meyer" , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46cbBM33T8z4SP0 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=VEXrvE+Q; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.85 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[d.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.85)[ip: (-9.38), ipnet: 2607:f8b0::/32(-2.64), asn: 15169(-2.20), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2019 20:14:04 -0000 On Mon, Sep 23, 2019, 9:06 PM Mark Johnston wrote: > On Mon, Sep 23, 2019 at 11:28:52AM -0700, Conrad Meyer wrote: > > Hi Mark, > > > > On Mon, Sep 23, 2019 at 7:14 AM Mark Johnston wrote: > > > > > > Author: markj > > > Date: Mon Sep 23 14:14:43 2019 > > > New Revision: 352623 > > > URL: https://svnweb.freebsd.org/changeset/base/352623 > > > > > > Log: > > > Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations. > > > > > > This is required for DPCPU and VNET data variable definitions to > work when > > > KLDs are linked as DSOs. R_X86_64_RELATIVE relocations should not > appear > > > in object files, so assert this in elf_relocaddr(). > > > > Is the goal to eventually link amd64 KLDs as DSOs? I might be > > confusing the terminology, but I believe amd64 .ko's today are > > unlinked ordinary object files, rather than shared objects. (I > > believe they use kern/link_elf_obj.c rather than kern/link_elf.c > > today.) > > > > If so: great! > > That's right, and that is indeed my goal. At least, I would like to > make the option available; with my patch set, it is possible to specify > the format at both the per-module and global levels. There are several > in-tree modules (some of the HighPoint RAID drivers, if you're curious) > that cannot be linked as DSOs because they contain a non-PIC blob, and > for now lld refuses to link them into a DSO. > That problem might be better solved by removing the highpount driver since they are old and abandon ware these days. I'm serious here, old stuff with low value getting in the way might be better off in our rearview mirror... Warner >