Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 08 May 2006 17:40:18 +0900
From:      Ganbold <ganbold@micom.mng.net>
To:        pyunyh@gmail.com
Cc:        freebsd-stable@FreeBSD.ORG
Subject:   Re: new sk driver [was: nve timeout (and down) regression?]
Message-ID:  <445F03F2.2080907@micom.mng.net>
In-Reply-To: <20060508082942.GF1239@cdnetworks.co.kr>
References:  <20060329104842.GA12679@cdnetworks.co.kr> <445EC5FA.10103@micom.mng.net> <20060508045559.GA1239@cdnetworks.co.kr> <445ED65C.1010703@micom.mng.net> <20060508055341.GC1239@cdnetworks.co.kr> <445EE188.4010402@micom.mng.net> <20060508061851.GD1239@cdnetworks.co.kr> <445EEA8B.3050508@micom.mng.net> <20060508071450.GE1239@cdnetworks.co.kr> <445EF8E6.1040201@micom.mng.net> <20060508082942.GF1239@cdnetworks.co.kr>

next in thread | previous in thread | raw e-mail | index | archive | help
Pyun YongHyeon wrote:
> On Mon, May 08, 2006 at 04:53:10PM +0900, Ganbold wrote:
>  > Pyun YongHyeon wrote:
>  > >On Mon, May 08, 2006 at 03:51:55PM +0900, Ganbold wrote:
>  > > > Pyun YongHyeon wrote:
>  > > > >On Mon, May 08, 2006 at 03:13:28PM +0900, Ganbold wrote:
>  > > > > > Pyun,
>  > > > > > 
>  > > > > > I can not apply the patch cleanly on 
>  > > > > > http://people.freebsd.org/~yongari/sk/sk_test2/if_sk.c
>  > > > > > What version of sk driver should I use?
>  > > > > > 
>  > > > >
>  > > > >The patch was generated against HEAD.
>  > > > >  
>  > > > I see, but how can I MFC to RELENG_6? I can't build it on RELENG_6.
>  > > > 
>  > >
>  > >Ok, copy the following files to /sys/dev/sk.(You may need to create
>  > >the directory on 6.x.)
>  > >>From the files in http://people.freebsd.org/~yongari/sk/sk_test2/
>  > >if_sk.c         -->     /sys/dev/sk
>  > >if_skreg.h      -->     /sys/dev/sk
>  > >xmaciireg.h     -->     /sys/dev/sk
>  > >yukonreg.h      -->     /sys/dev/sk
>  > >
>  > >And
>  > >Makefile        -->     /sys/modules/sk
>  > >  
>  > Still can't compile.
>  > 
>  > cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE 
>  > -nostdinc -I-   -I. -I@ -I@/contrib/altq -I@/../include -I/usr/include 
>  > -finline-limit=8000 -fno-common  -mno-align-long-strings 
>  > -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 
>  > -ffreestanding -Wall -Wredundant-decls -Wnested-externs 
>  > -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline 
>  > -Wcast-qual  -fformat-extensions -std=c99 -c 
>  > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c
>  > In file included from /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:130:
>  > @/dev/sk/if_skreg.h:995:15: no newline at end of file
>
> I can't understand. There *IS* a newline at the end of file.
> Checking with hd(1) shows a newline character.
>
> If it break it should also break HEAD tinderbox too.
>   
I think new line is not a problem. The problematic line says 
"/usr/src/sys/modules/sk/../../dev/sk/if_sk.c:146: error: elements of 
array `sk_devs' have incomplete type"

daemon# make
Warning: Object directory not changed from original /usr/src/sys/modules/sk
cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE 
-nostdinc -I-   -I. -I@ -I@/contrib/altq -I@/../include 
-finline-limit=8000 -fno-common  -mno-align-long-strings 
-mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 
-ffreestanding -Wall -Wredundant-decls -Wnested-externs 
-Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline 
-Wcast-qual  -fformat-extensions -std=c99 -c 
/usr/src/sys/modules/sk/../../dev/sk/if_sk.c
/usr/src/sys/modules/sk/../../dev/sk/if_sk.c:146: error: elements of 
array `sk_devs' have incomplete type
/usr/src/sys/modules/sk/../../dev/sk/if_sk.c:148: warning: excess 
elements in struct initializer
...

Ganbold

>  > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:146: error: elements of 
>  > array `sk_devs' have incomplete type
>  > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:148: warning: excess 
>  > elements in struct initializer
>  > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:148: warning: (near 
>  > initialization for `sk_devs[0]')
>  > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:149: warning: excess 
>  > elements in struct initializer
>  > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:149: warning: (near 
>  > initialization for `sk_devs[0]')
>  > ...
>  > 
>  > Ganbold
>  > > > thanks,
>  > > > 
>  > > > Ganbold
>  > > > 
>  > > > > > Ganbold
>  > > > > > 
>  > > > >  
>  > > > 
>  > >
>  > >  
>  > 
>
>   




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?445F03F2.2080907>