Date: Thu, 17 Jun 1999 13:44:18 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Peter Wemm <peter@netplex.com.au> Cc: Nate Williams <nate@mt.sri.com>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/nfs nfs_socket.c Message-ID: <Pine.BSF.4.05.9906171343170.59161-100000@herring.nlsystems.com> In-Reply-To: <199906070342.UAA04118@peterw.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 6 Jun 1999, Peter Wemm wrote: > Nate Williams wrote: > > > peter 1999/06/06 17:53:13 PDT > > > > > > Modified files: (Branch: RELENG_2_1_0) > > > sys/nfs nfs_socket.c > > > Log: > > > MFC: don't clobber a mbuf pointer > > > > Now *this* is a commit on a *very* old branch. :) > > Heh. There are a number of machines running it here... I have a handfull > more changes, I was debating whether to bother or not, so tried a few of > the easier ones. > > > Thanks for back-porting these changes! > > What's really bugging me right now is the good old block-of-nulls in > vnode_if.c etc, and that's on an old 2.2.7-S client of a fairly recent > 3.1-S server. The server copy is correct, and the client has the corrupted > copy. It's even wierder that this client is the one that wrote the file in > the first place, just moments before it tried to compile it and failed. > > I'm pretty sure I recall this particular problem getting fixed, but I don't > remember if it was one of John Dyson's commits a while ago, one of Doug's, > or one of Matt's in 4.0... I wish I had been paying more attention :-). > > The block of null chars goes from 0x3000 to 0x38bd.. Kinda wierd ending > offset - nowhere near a block boundary - but it reminds me of the changes > Matt made in his recent jumbo nfs patch to rework the piecemeal writes for > the valid and/or dirty offset/end pointers. However, the end of the nulls > is right in the middle of "&vop_mkdir_desc,\n", specifically everything > except the "sc,\n" was clobbered. It doesn't even look like it would match > a partial write boundary. I have a vague memory that this was fixed when I implemented VOP_GETPAGES (or maybe VOP_PUTPAGES). -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9906171343170.59161-100000>