From owner-cvs-all@FreeBSD.ORG Sat Mar 13 02:10:18 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E60C16A4CF; Sat, 13 Mar 2004 02:10:18 -0800 (PST) Received: from mailout03.sul.t-online.com (mailout03.sul.t-online.com [194.25.134.81]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3345B43D3F; Sat, 13 Mar 2004 02:10:18 -0800 (PST) (envelope-from Alexander@Leidinger.net) Received: from fwd00.aul.t-online.de by mailout03.sul.t-online.com with smtp id 1B265w-0001fj-06; Sat, 13 Mar 2004 11:10:16 +0100 Received: from Andro-Beta.Leidinger.net (S94Ny+Zl8e-9f01WrHTgClBFt493rfbsW6Obq+HtSBOQw6c5X2eAoh@[217.83.23.16]) by fmrl00.sul.t-online.com with esmtp id 1B265t-0QnARs0; Sat, 13 Mar 2004 11:10:13 +0100 Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) i2DAAAtn030509; Sat, 13 Mar 2004 11:10:11 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from Magellan.Leidinger.net (netchild@localhost [127.0.0.1]) i2DAAAep007063; Sat, 13 Mar 2004 11:10:10 +0100 (CET) (envelope-from Alexander@Leidinger.net) Date: Sat, 13 Mar 2004 11:10:10 +0100 From: Alexander Leidinger To: cvs-src@freebsd.org Message-Id: <20040313111010.6493143f@Magellan.Leidinger.net> In-Reply-To: <20040312224630.GG35475@elvis.mu.org> References: <20040312214545.7F3C216A4FA@hub.freebsd.org> <20040312223315.GE4588@ip.net.ua> <20040312224630.GG35475@elvis.mu.org> X-Mailer: Sylpheed version 0.9.9claws (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Seen: false X-ID: S94Ny+Zl8e-9f01WrHTgClBFt493rfbsW6Obq+HtSBOQw6c5X2eAoh@t-dialin.net cc: Maxime Henrion cc: Tom Rhodes cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/arc/include arcfuncs.h src/sys/boot/i386/boot2 boot2.c src/sys/dev/aic7xxx/aicasm aicasm.c iir.h src/sys/dev/isp ispvar.h src/sys/dev/mcd mcdreg.h ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2004 10:10:18 -0000 On Fri, 12 Mar 2004 23:46:30 +0100 Maxime Henrion wrote: > It would be even better IMHO if you had used __GNUC_PREREQ__ in other > files, to simplify all those tests. It would be better to change this to feature tests and set the appropriate defines at the beginning depending on the compiler used. This way you only have to check the compiler once. This was suggested to me by Matthew Dillon a while ago, but I think such a change should be separate from the icc change, as it makes it more obvious what happens in each change (so it's more easy to review). Bye, Alexander. -- I will be available to get hired in April 2004. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7