From owner-freebsd-fs@FreeBSD.ORG  Wed Apr 22 07:07:12 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4412D1065672;
	Wed, 22 Apr 2009 07:07:12 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 138928FC16;
	Wed, 22 Apr 2009 07:07:10 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA04661;
	Wed, 22 Apr 2009 10:07:09 +0300 (EEST)
	(envelope-from avg@icyb.net.ua)
Received: from localhost.topspin.kiev.ua ([127.0.0.1] helo=edge.pp.kiev.ua)
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1LwWY1-000Eoj-BI; Wed, 22 Apr 2009 10:07:09 +0300
Message-ID: <49EEC21C.7020106@icyb.net.ua>
Date: Wed, 22 Apr 2009 10:07:08 +0300
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.21 (X11/20090406)
MIME-Version: 1.0
To: Ivan Voras <ivoras@freebsd.org>
References: <49EDCA21.70908@icyb.net.ua> <gskrld$vo0$1@ger.gmane.org>
	<49EDF80F.3070105@icyb.net.ua> <49EDF995.2050508@freebsd.org>
In-Reply-To: <49EDF995.2050508@freebsd.org>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org
Subject: Re: glabel for ufs: size check is overzealous?
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2009 07:07:13 -0000


Thinking more about it - maybe that check is useful for finding out what
geom provider a filesystem actually belongs too. But I am not sure.

E.g. what should happen in the following case?
I create partitions ad4s1a and ad4s2a.
I create gmirror rootgm using these partitions.
I create a filesystem on rootgm with label rootfs.
Right now, with my local patch, during boot glabel seems to do "tasting"
before gmirror is activated and so it thinks that rootfs is label of
filesystem on ad4s1a.

I think that this wouldn't have happened without my patch.
But, OTOH, I think that this is not the problem of the patch, this is a
problem of glabel starting before gmirror. But this is insolvable in
principle - what of gmirror is started later manually.

So after all the current code makes the most sense for most common usage
pattern. And thus I shall shut up :-)

-- 
Andriy Gapon