From owner-cvs-all  Sun Apr  7 22:34: 1 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3C8C037B404; Sun,  7 Apr 2002 22:33:57 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id PAA03307;
	Mon, 8 Apr 2002 15:33:55 +1000
Date: Mon, 8 Apr 2002 15:33:57 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Poul-Henning Kamp <phk@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sbin/disklabel Makefile disklabel.c
In-Reply-To: <200204071057.g37Av1i39601@freefall.freebsd.org>
Message-ID: <20020408152740.N5678-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 7 Apr 2002, Poul-Henning Kamp wrote:

> phk         2002/04/07 03:57:00 PDT
>
>   Modified files:
>     sbin/disklabel       Makefile disklabel.c
>   Log:
>   Get us to WARNS=2 with a bit of constification and some printf fiddling.

WARNS=2 bogusly overrides the default, and "=" instead of "?=" breaks
overriding the default.  "=" in WARNS=0 had the same bug.

>   Pick up the c-partitions magicness from sys/disklabel.h instead
>   of defining our own magicness for it, remove trivial comment.

This was one of the many bugs in rev.1.35.  The committers and approvers
of that sort of promised to clean it up, but never did.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message