From owner-freebsd-audit Fri Nov 29 7:34:51 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32E6937B401 for ; Fri, 29 Nov 2002 07:34:49 -0800 (PST) Received: from mail.gmx.net (mail.gmx.net [213.165.65.60]) by mx1.FreeBSD.org (Postfix) with SMTP id 238E343EA9 for ; Fri, 29 Nov 2002 07:34:48 -0800 (PST) (envelope-from csharp@gmx.net) Received: (qmail 18237 invoked by uid 0); 29 Nov 2002 15:34:46 -0000 Received: from pd9552198.dip.t-dialin.net (HELO dagon.cthulhu.net) (217.85.33.152) by mail.gmx.net (mp004-rz3) with SMTP; 29 Nov 2002 15:34:46 -0000 Received: by dagon.cthulhu.net (Postfix, from userid 1001) id DED2B6191; Fri, 29 Nov 2002 16:37:42 +0100 (CET) Date: Fri, 29 Nov 2002 16:37:42 +0100 From: Christopher Sharp To: freebsd-audit@freebsd.org Subject: patch for the make regression test Message-ID: <20021129153742.GA11955@gmx.net> Mail-Followup-To: freebsd-audit@freebsd.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline User-Agent: Mutt/1.5.1i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, as I stated in an email I wrote to -current yesterday I'm not really happy with the output of the regression test for make which is run before every command in src. Attached you can find a patch to make it IMHO nicer and shorter. I would be really glad if something like this or this patch could get commited. Comments ? - Christopher --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="make.Makefile.patch" --- Makefile.old Thu Nov 28 14:21:32 2002 +++ Makefile Fri Nov 29 16:30:57 2002 @@ -19,28 +19,29 @@ NIL= all: - @echo "Running test variables" + @echo "Doing regression tests for make:" + @echo -n "Running test variables... " @echo 1:${DATA1} 2:${DATA2} 3:${DATA3} 4:${DATA4} 5:${DATA5} | \ diff -u ${.CURDIR}/regress.variables.out - || ${MAKE} failure - @echo "PASS: Test variables detected no regression, output matches." - @echo "Running test targets" + @echo "ok" + @echo -n "Running test targets... " @${MAKE} double || ${MAKE} failure - @echo "PASS: Test targets detected no regression." - @echo "Running test sysvmatch" + @echo "ok" + @echo -n "Running test sysvmatch... " @${MAKE} sysvmatch || ${MAKE} failure - @echo "PASS: Test sysvmatch detected no regression." - @echo "Running test lhs_expn" + @echo "ok" + @echo -n "Running test lhs_expn... " @! ${MAKE} lhs_expn && true || ${MAKE} failure - @echo "PASS: Test lhs_expn detected no regression." - @echo "Running test notdef" + @echo "ok" + @echo -n "Running test notdef... " @${MAKE} notdef || ${MAKE} failure - @echo "PASS: Test notdef detected no regression." - @echo "Running test modifiers" + @echo "ok" + @echo -n "Running test modifiers... " @${MAKE} modifiers || ${MAKE} failure - @echo "PASS: Test modifiers detected no regression." - @echo "Running test funny_targets" + @echo "ok" + @echo -n "Running test funny_targets... " @${MAKE} funny_targets || ${MAKE} failure - @echo "PASS: Test funny_targets detected no regression." + @echo "ok" .if make(double) # Doubly-defined targets. make(1) will warn, but use the "right" one. If it @@ -91,5 +92,5 @@ .endif failure: - @echo "FAIL: Test failed: regression detected. See above." + @echo "failed (regression detected)" @false --FL5UXtIhxfXey3p5-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message