From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 01:24:15 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0E8A48D2; Mon, 16 Feb 2015 01:24:15 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8187F16A; Mon, 16 Feb 2015 01:24:13 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1G1O9Y2047159 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 16 Feb 2015 04:24:09 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1G1O9BC047158; Mon, 16 Feb 2015 04:24:09 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 16 Feb 2015 04:24:09 +0300 From: Gleb Smirnoff To: Craig Rodrigues Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <20150216012409.GZ15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> <20150215190100.GQ15484@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Nikos Vassiliadis , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 01:24:15 -0000 On Sun, Feb 15, 2015 at 01:26:18PM -0800, Craig Rodrigues wrote: C> What are the problems in 276746 that you were unhappy with C> besides being unable to kldunload PF? They were listed in Message-ID: <20150121214445.GL15484@FreeBSD.org>. Also, the fact that commit required a serie of followup commits, means that initial commit was not tested properly. And did I ever said "being unable to kldunload PF"? This is what I said: > You blindly remove kproc_exit(). What do you think would happen on > 'kldunload -f pf'? If you can't grok that, you probably don't even understand the code you committed. Since what is going to happen is kernel panic. C> With 276746, without the follow-on fixes, if you kldunload PF C> while VIMAGE is unabled, the kernel panics. That seems worse C> than being unable to kldunload PF. So, without 276746 pf would panic with VIMAGE. And after 276747 pf would panic without VIMAGE. And yes, this is worse. Since backing out only 276747 leads to unbuildable kernel, I ended with backing out all chain of commits. C> If I submit another patch, I am just going to commit it, C> but I don't know if you will be unhappy and revert it. No, you will wait for review. -- Totus tuus, Glebius.