Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Feb 2018 09:19:08 -0700
From:      Alan Somers <asomers@freebsd.org>
To:        Wojciech Macek <wma@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme
Message-ID:  <CAOtMX2iP6fHQz%2BEKmKLQu_EUdydxh0hY9gxPPygUucn1T-2fxw@mail.gmail.com>
In-Reply-To: <201802221332.w1MDWVao004564@repo.freebsd.org>
References:  <201802221332.w1MDWVao004564@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek <wma@freebsd.org> wrote:

> Author: wma
> Date: Thu Feb 22 13:32:31 2018
> New Revision: 329824
> URL: https://svnweb.freebsd.org/changeset/base/329824
>
> Log:
>   NVMe: Add big-endian support
>
>   Remove bitfields from defined structures as they are not portable.
>   Instead use shift and mask macros in the driver and nvmecontrol
> application.
>
>   NVMe is now working on powerpc64 host.
>
>   Submitted by:          Michal Stanek <mst@semihalf.com>
>   Obtained from:         Semihalf
>   Reviewed by:           imp, wma
>   Sponsored by:          IBM, QCM Technologies
>   Differential revision: https://reviews.freebsd.org/D13916
>

It looks like this change broke the build with Clang:

--- ioctl.pico ---
In file included from ioctl.c:32:
In file included from
/usr/home/alans/freebsd/head/sys/cam/scsi/scsi_pass.h:35:
In file included from /usr/home/alans/freebsd/head/sys/cam/cam_ccb.h:46:
In file included from
/usr/home/alans/freebsd/head/sys/cam/nvme/nvme_all.h:34:
/usr/home/alans/freebsd/head/sys/dev/nvme/nvme.h:1187:26: error: unused
parameter 'p' [-Werror,-Wunused-parameter]
void    nvme_le128toh(void *p)

-Alan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2iP6fHQz%2BEKmKLQu_EUdydxh0hY9gxPPygUucn1T-2fxw>