From owner-freebsd-current@FreeBSD.ORG Thu Mar 20 20:16:11 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D9E5C104 for ; Thu, 20 Mar 2014 20:16:11 +0000 (UTC) Received: from mail-pb0-f52.google.com (mail-pb0-f52.google.com [209.85.160.52]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A7DD8C5A for ; Thu, 20 Mar 2014 20:16:11 +0000 (UTC) Received: by mail-pb0-f52.google.com with SMTP id rr13so1444453pbb.39 for ; Thu, 20 Mar 2014 13:16:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=mvTXd1EQ5889xUUaDofpwjxpipHOA6Jvduaz3e0B7oU=; b=LAkZ95ju7m2T6crInzwJJvbDMydUzChWbLANtTYWUtxJoI2UWGpxn1JFcSSn1TNCQD K3thfPiOqp5tgurMHP725w7LETGOXJr5XVhzm5EQK0r+HSgNpoUems4xdVw8Il8IfeRT 2n8yzgatX5/IvXCBSyxFm+/yKMamlAH52pBuDT+V5TayrsbWazjs3TOEotUOq1mgFfAS 8zY4DIWOvjXosSbFKYzAOjw2Q5wbrSM1zZSIByZwFcG/USTLwmIaZ7xElcR4CWCukBL5 YIMYi0vJ934YLu1hGEcY+XaaNT3hnjN/OrqeBQE7muCTYsEuoH6dMppqm31NhjkIfkWp PGBQ== X-Gm-Message-State: ALoCoQlH9J8BLgi/rgIZnwiwRUf2qBW5mVITcaIrrag5WrCpWB9mfRCFmsi0IqCgBelNOdlvXrlM X-Received: by 10.66.142.132 with SMTP id rw4mr51000878pab.6.1395346570850; Thu, 20 Mar 2014 13:16:10 -0700 (PDT) Received: from lgmac-scingram.corp.netflix.com (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id kt8sm14769217pab.7.2014.03.20.13.16.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Mar 2014 13:16:09 -0700 (PDT) Sender: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: Building with external toolchain was broken 6 months ago with r255187 From: Warner Losh In-Reply-To: <20140320182440.GN32089@funkthat.com> Date: Thu, 20 Mar 2014 14:16:08 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <323697891.20140319013757@serebryakov.spb.ru> <20140318220140.GA32089@funkthat.com> <7423EF12-9DD4-4C03-9FF6-7BAAB75820F6@lists.zabbadoz.net> <201403201008.48610.jhb@freebsd.org> <491ECF6C-D868-4971-903E-5F380AB7E05B@FreeBSD.org> <20140320182440.GN32089@funkthat.com> To: John-Mark Gurney X-Mailer: Apple Mail (2.1874) Cc: Lev Serebryakov , "Bjoern A. Zeeb" , FreeBSD Current , David Chisnall X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Mar 2014 20:16:12 -0000 On Mar 20, 2014, at 12:24 PM, John-Mark Gurney wrote: > Warner Losh wrote this message on Thu, Mar 20, 2014 at 11:30 -0600: >>=20 >> On Mar 20, 2014, at 8:25 AM, David Chisnall = wrote: >>=20 >>> On 20 Mar 2014, at 14:08, John Baldwin wrote: >>>=20 >>>> No, the compiler should provide a working "wmmintrin.h" header in = one of >>>> its built-in paths if it supports the AES instructions. This is = akin to >>>> saying that code that uses "stdio.h" should use -I/usr/src/include. >>>=20 >>> It does, however our build system then explicitly says to the = compiler 'don't use your built-it paths because they may contain = declarations that contradict the FreeBSD ones' by means of the sysroot = argument. When not using an external toolchain, we put the compiler's = internal headers inside the sysroot. >>=20 >> Sounds like we?re building the sysroot wrong then. >=20 > I'm not familar w/ cross tools, are cross tools suppose to "just = work", > or do you still require building kernel-toolchain? The wiki doesn't > talk about buildkernel... If it's still required to build > kernel-toolchain before buildkernel, one option is to remove the > exclusion of the _includes target from kernel-toolchain, though = _includes > doesn't appear to install the header... It looks like it never > goes into lib/clang to install them, though I'm not sure if it is = suppose > to or not.. If you use COMPILER_TYPE=3Dgcc, it doesn't go into the = proper > gcc subdir to install them either=85 I=92m saying that whatever is building the sysroot is building it wrong. = I haven=92t looked at the details enough to know where the fault lies. If the files aren=92t = there, that=92s a bug and adding hacks for clang is not the right way to fix the bug. > In investigating this, it looks like we might have a make rule = conflict > in usr.sbin/bsdconfig... It has a subdir includes, but bsd.subdir.mk > also defines a rule includes (for building inclues) which results in > this: > make[4]: "/usr/src/share/mk/bsd.subdir.mk" line 85: warning: duplicate = script for target "includes" ignored > make[4]: "/usr/src/share/mk/bsd.subdir.mk" line 69: warning: using = previous script for "includes" defined here That=92s likely an orthogonal issue=85 Warner