Date: Fri, 24 May 2019 06:48:52 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Alexey Dokuchaev <danfe@freebsd.org>,Kubilay Kocak <koobs@freebsd.org> Cc: Rene Ladan <rene@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r502461 - in head/www/chromium: . files Message-ID: <D1ACE4B9-14D9-41CF-9CB1-3B3FC4253895@cschubert.com> In-Reply-To: <20190524125813.GA80150@FreeBSD.org> References: <201905241234.x4OCYwWJ055964@repo.freebsd.org> <20190524124243.GA55965@FreeBSD.org> <03e929e1-4f54-3017-1629-3965dd63ee17@FreeBSD.org> <20190524125813.GA80150@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 24, 2019 5:58:13 AM PDT, Alexey Dokuchaev <danfe@freebsd=2Eorg> wrot= e: >On Fri, May 24, 2019 at 10:47:36PM +1000, Kubilay Kocak wrote: >> On 24/05/2019 10:42 pm, Alexey Dokuchaev wrote: >> > On Fri, May 24, 2019 at 12:34:58PM +0000, Rene Ladan wrote: >> >> New Revision: 502461 >> >> URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/502461 >> >> >> >> Log: >> >> www/chromium: update to 74=2E0=2E3729=2E157 >> >> =20 >> >> Submitted by: Matthias Wolf via GitHub (#150 #151) >> >> MFH: 2019Q2 >> >=20 >> > Many patches that were modified only changed in metainfo or context >> > (+/- few lines) and thus just cluttered this very noisy commit for >> > no real benefit=2E >> >=20 >> > Please try to exclude them from the commit batch next time to >reduce >> > amount of repochurn=2E >>=20 >> fwiw, makepatch is now ignoring metadata only changes=2E Not sure when >> this new feature crept in=2E > >Technically, line changes are not strictly metadata only changes, and >the old patch might not apply=2E However, most of the times new address >is within a few lines, and patch(1) can easily find the right context >even when address is off by several hundred lines=2E > >It might not be very important for small commit batch, but for large >commits, minizing the diff becomes essential since it greatly helps >to understand, rollback, or/and replay changes (especially if there >is some local work in place, e=2Eg=2E some custom patches)=2E > >=2E/danfe +1=2E Anyone reviewing the history months or years from now will have a much har= der time parsing out the significant parts of this commit from the gratuito= us=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert <Cy=2ESchubert@cschubert=2Ecom> FreeBSD UNIX: <cy@FreeBSD=2Eorg> Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D1ACE4B9-14D9-41CF-9CB1-3B3FC4253895>