Date: Sun, 27 May 2012 16:54:55 +0200 From: Oliver Pinter <oliver.pntr@gmail.com> To: Niclas Zeising <zeising@daemonic.se> Cc: ports@freebsd.org, Mel Flynn <rflynn@acsalaska.net>, x11@freebsd.org Subject: Re: libX11 and clang: compile error Message-ID: <CAPjTQNEeSYPbtKQeoaeVHiWAB1=_aUFm=Uq%2B0_8zhSGrgjDwgA@mail.gmail.com> In-Reply-To: <4FC1FCF9.4090305@daemonic.se> References: <CAPjTQNHCHCPNm=6%2BinkDmbnj4%2BW1kdcXkwFxS8LURj3kqWPDmg@mail.gmail.com> <4FC1082A.9090801@acsalaska.net> <CAPjTQNG-8mosRuun-u%2BWHVVAu_VydDhdLekrQ8hOEQ%2BPML-3Zg@mail.gmail.com> <4FC112A1.7080600@acsalaska.net> <CAPjTQNEvV_%2BVT2iE_1EHDdR_nciMc1yWLFGnDKyqd6nu-wek2Q@mail.gmail.com> <4FC128C6.1020902@acsalaska.net> <CAPjTQNEuRU-06_LSei7OCnev-pBSYdgcjuuGMuEN-%2B33aswFVw@mail.gmail.com> <4FC1FCF9.4090305@daemonic.se>
next in thread | previous in thread | raw e-mail | index | archive | help
--001636c9321dd8fbef04c105c860 Content-Type: text/plain; charset=ISO-8859-1 On 5/27/12, Niclas Zeising <zeising@daemonic.se> wrote: > On 2012-05-26 21:06, Oliver Pinter wrote: >> On 5/26/12, Mel Flynn <rflynn@acsalaska.net> wrote: >>> On 26-5-2012 20:40, Oliver Pinter wrote: >>>> On 5/26/12, Mel Flynn <rflynn@acsalaska.net> wrote: >>>>> On 26-5-2012 19:17, Oliver Pinter wrote: >>>>>> I think src.conf is relevant, while it changes the system behavior, >>>>>> as >>>>>> changed the default cc from gcc-4.2 to clang. >>>>> >>>>> Thinking it doesn't make it so. Run: >>>>> grep _WITHOUT_SRCCONF /usr/share/mk/*.mk >>>>> >>>>> Then investigate. >>>>> Setting CC in /etc/src.conf has *no effect on CC passed to the ports*. >>>>> Really. It does not. >>>>> The file that can do that is /etc/make.conf. >>>>> Another way is setting CC in your environment variables, through >>>>> /etc/login.conf, /etc/yourshellrc ~/.profile ~/.[cz]?shrc and what >>>>> not. >>>>> >>>>> In order to debug your issue, you should provide the output of what >>>>> make >>>>> thinks CC and CPP are and backtrack where they are set. >>>>> Start with: >>>>> make -C /usr/ports/x11/libX11 -V CC -V CPP >>>>> -- >>>>> Mel >>>>> >>>> >>>> After setting WITH_CLANG_IS_CC in src.conf the base system cc,cpp and >>>> c++ has changed: >>> >>> See ports/166373. >>> >>> Also, the fact that your /usr/bin/cpp == clang-cpp is relevant! >>> Especially if you report: >>>> Somewhere in config* or Makefile are a hardcoded /usr/bin/cpp ... >>> >>> -- >>> Mel >>> >> >> this is a workaround, see the attached file > > This is a known issue and is being looked into. The issue is that clang > cpp and gcc cpp behaves differently wrt. -traditional. > We will try to find a general approach that works for all xorg ports > that use cpp -traditional, probably regardless of the regular compiler > used. > > Regards! > -- > Niclas Zeising > Hi! Attached a patch - the idea mostly based on ports/166373, but extended with runtime compiler checking. With this patch the xorg related ports building fine. --001636c9321dd8fbef04c105c860 Content-Type: text/x-diff; charset=US-ASCII; name="bsd.xorg.mk.diff" Content-Disposition: attachment; filename="bsd.xorg.mk.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 LS0tIGJzZC54b3JnLm1rLm9yaWcJMjAxMi0wNS0yNyAxNjozMToxOS4wMDAwMDAwMDAgKzAyMDAK KysrIGJzZC54b3JnLm1rCTIwMTItMDUtMjcgMTY6NTA6MTkuMDAwMDAwMDAwICswMjAwCkBAIC0y Nyw2ICsyNywxMyBAQAogIyBwcm90byAtIGluc3RhbGwgLnBjIGZpbGUsIG5vIGRlcGVuZGVuY2ll cywgbmVlZGVkIG9ubHkgYXQgYnVpbGQgdGltZSBmb3IgbW9zdCBvZiB0aGVtCiAjIHhzZXJ2ZXIg LSB0aGVyZSdzIG9ubHkgb25lIGF0bSwgSSBndWVzcyBldmVyeXRoaW5nIGNhbiBmaXQgaW50byB0 aGUgcG9ydCBpdHNlbGYKIAorIyBYWFggT1AgLSB3b3JrYXJvdW5kIHRvIGJ1aWxkIHhvcmcgd2l0 aCBjbGFuZworT1BfV0FfQ1BQX1ZFUiE9IGNjIC0tdmVyc2lvbgorLmlmICR7T1BfV0FfQ1BQX1ZF UjpNY2xhbmd9CitSQVdDUFA/PSAvdXNyL2Jpbi9nY3BwCitDT05GSUdVUkVfQVJHUys9IFJBV0NQ UD0ke1JBV0NQUH0KKy5lbmRpZgorCiAuaWYgZGVmaW5lZChYT1JHX0NBVCkKICMgRGVmYXVsdCB2 YXJpYWJsZXMsIGNvbW1vbiB0byBhbGwgbmV3IG1vZHVsYXIgeG9yZyBwb3J0cy4KIC5pZiAhZGVm aW5lZChVU0VfVEdaKQo= --001636c9321dd8fbef04c105c860--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNEeSYPbtKQeoaeVHiWAB1=_aUFm=Uq%2B0_8zhSGrgjDwgA>