Date: Fri, 8 Jun 2018 10:58:37 -0400 From: Diane Bruce <db@db.net> To: Ed Maste <emaste@freebsd.org> Cc: Kirk McKusick <mckusick@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r334814 - head/sbin/dump Message-ID: <20180608145837.GA31398@night.db.net> In-Reply-To: <CAPyFy2DxmjVw57vu9Cbn7X1qfgR58UtTzvMk2rzEHxfhBHm79g@mail.gmail.com> References: <201806072049.w57Kn1Mk057119@repo.freebsd.org> <CAPyFy2DxmjVw57vu9Cbn7X1qfgR58UtTzvMk2rzEHxfhBHm79g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 08, 2018 at 10:08:25AM -0400, Ed Maste wrote: > On 7 June 2018 at 16:49, Kirk McKusick <mckusick@freebsd.org> wrote: > > Author: mckusick > > Date: Thu Jun 7 20:49:01 2018 > > New Revision: 334814 > > URL: https://svnweb.freebsd.org/changeset/base/334814 > > > > Log: > > Ensure proper initialization of superblock. > > > ... > > --- head/sbin/dump/main.c Thu Jun 7 19:57:55 2018 (r334813) > > +++ head/sbin/dump/main.c Thu Jun 7 20:49:01 2018 (r334814) > > @@ -433,6 +433,7 @@ main(int argc, char *argv[]) > > msgtail("to %s\n", tape); > > > > sync(); > > + sblock = NULL; > > if ((ret = sbget(diskfd, &sblock, -1)) != 0) { > > sblock is initialized to NULL at the beginning of ffs_sbget, so I'm I saw that under lldb when I checked the assembler code. > not really sure what's happening here. ditto. But another data point this morning. I ran stock dump on a spinning rust portable drive I have with me today. It worked fine. the disk in the laptop is a SSD SATA. Another data point , the bug failed to manifest until my system had been running a few minutes. e.g. it did the demo mode failure when I tried to show it to jhibbits... I will boot from the spinning rust and fsck the ssd again. @dteske and I thoroughly fsck_ufs fsck_ffs etc. yesterday but I'll try again today from another root disk. That's an obvious one. > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- - db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180608145837.GA31398>