Date: Sat, 26 Oct 2002 15:05:00 -0700 (PDT) From: Nate Lawson <nate@root.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: arch@freebsd.org Subject: Re: NO_WERROR and the kernel Message-ID: <Pine.BSF.4.21.0210261503220.78632-100000@root.org> In-Reply-To: <20021026.111312.21077495.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 26 Oct 2002, M. Warner Losh wrote: > Is there a reason that NO_WERROR doesn't work with the kernel? Would > there be a reason not to include the following patch? > > Warner > > Index: kern.pre.mk > =================================================================== > RCS file: /cache/ncvs/src/sys/conf/kern.pre.mk,v > retrieving revision 1.19 > diff -u -r1.19 kern.pre.mk > --- kern.pre.mk 17 Sep 2002 09:07:06 -0000 1.19 > +++ kern.pre.mk 26 Oct 2002 17:11:51 -0000 > @@ -48,7 +48,11 @@ > .endif > .endif > DEFINED_PROF= ${PROF} > +.if !defined(NO_WERROR) > WERROR?= -Werror > +.else > +WERROR?= > +.endif > > # Put configuration-specific C flags last (except for ${PROF}) so that they > # can override the others. It used to be in there and was yanked on purpose (memory says phk but may be wrong). The idea is that too many were running with NO_WERROR=yes (especially since that was the recommended way of doing things for so long) and the only way to get things in shape was to remove it. You can get around it anyway when things are broken by doing WERROR= in /etc/make.conf -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0210261503220.78632-100000>