Date: Sun, 17 May 2009 11:09:30 +0300 From: Ion-Mihai Tetcu <itetcu@freebsd.org> To: Scot Hetzel <swhetzel@gmail.com> Cc: Doug Barton <dougb@freebsd.org>, QAT@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org, ports@freebsd.org, cvs-ports@freebsd.org, imp@freebsd.org Subject: Re: cvs commit: ports/net Makefile ports/net/bwi-firmware-kmod Makefile distinfo pkg-descr pkg-plist Message-ID: <20090517110930.1a4c12b1@it.buh.tecnik93.com> In-Reply-To: <790a9fff0905162352xc2fa29cl9cf411cf9e6b3a22@mail.gmail.com> References: <200905092141.n49LfomV031060@repoman.freebsd.org> <20090510162002.A2CAA8FC4E@release.ixsystems.com> <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.com> <4A0F6548.1010205@FreeBSD.org> <20090517084754.5003f6f9@it.buh.tecnik93.com> <790a9fff0905162352xc2fa29cl9cf411cf9e6b3a22@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/JihvPFjQJs7hqc3w79kGdvR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 17 May 2009 01:52:10 -0500 Scot Hetzel <swhetzel@gmail.com> wrote: > On Sun, May 17, 2009 at 12:47 AM, Ion-Mihai Tetcu > <itetcu@freebsd.org> wrote: > > On Sat, 16 May 2009 18:15:52 -0700 > > Doug Barton <dougb@FreeBSD.org> wrote: > > > >> Scot Hetzel wrote: > >> > This shouldn't be flaged as an mtree error. =C2=A0The reason that > >> > linker.hints was left behind is due to this file is generated by > >> > kldxref. =C2=A0The port/package runs kldxref during the install of t= he > >> > firmware module to update the existing or create a linker.hints > >> > file, and when the package is removed, it runs kldxref again to > >> > clean up the linker.hints file to only contain the modules > >> > in /boot/modules. =C2=A0It has no way to know if it is safe to remove > >> > this file. > >> > >> Would it be safe to remove if it's empty? > > > > Doh! I don't see why not. :-) > > > I performed a test where only bwi_v3_ucode.ko was installed into a > directory, ran kldxref on the directory and it created a 88 byte > linker.hints file. I then removed the kernel module from the > directory, ran kldxref. Kldxref removed the empty linker.hints file. >=20 > So it looks like all kernel module ports should have this code added > to their pkg-plists: >=20 > %%KMODDIR%%/kernel_module.ko > @exec kldxref %%KMODDIR%% > @unexec kldxref %%KMODDIR%% >=20 >=20 > The bwi-firmware-kmod port had these changes applied on 5/16, and QAT > shouldn't be reporting this error any more. I'll commit to the rest of them if maintainers don't fix them themselves in a few days. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/JihvPFjQJs7hqc3w79kGdvR Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkoPxjsACgkQJ7GIuiH/oeVPEACfTcTIUzgQd4gFLQydjFn4slrt edwAn2d+OXRj7DgbQeJT3+YrWJR0Tzu9 =IS1t -----END PGP SIGNATURE----- --Sig_/JihvPFjQJs7hqc3w79kGdvR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090517110930.1a4c12b1>