From owner-freebsd-stable@FreeBSD.ORG Wed Oct 30 02:17:05 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8A1E7E4E for ; Wed, 30 Oct 2013 02:17:05 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pb0-x22b.google.com (mail-pb0-x22b.google.com [IPv6:2607:f8b0:400e:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 60F312A82 for ; Wed, 30 Oct 2013 02:17:05 +0000 (UTC) Received: by mail-pb0-f43.google.com with SMTP id md4so692164pbc.2 for ; Tue, 29 Oct 2013 19:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=PsQNQ6VqqqzNsB2DGhMknlAiSy96EXVynfCOrNXRums=; b=InC0i9ka0OuzMFXUm1Vwoh3+47ShufcNNOYnZJG6xt7Wi4H+igVBU7pyTpV5Tmc8oU yOqksluaih3XQMVDliGYWkPvdD0ZQCZEJZ010ICiH96mZ3z0rznki000BNGQ/pOieTMd 6t0zViy+lf3KOVyeBv8kFhjOifsik3+MVYI9cPPit1IjUa+/Tue9ujAEtmQZeIou5mzH bS1wuSgb+jGs5azOk1JzKD+sReuEKzpcBfEiS32RvU3Tu8MWqk2GkeEMyXszfNOaezZq MLFsGNpJREUK9BbwcRZEvy8gOn2lRqIJh1/gWKTRPkM0mpAuWtkzMvP2EDoUlHrhcdl2 UFaQ== X-Received: by 10.67.3.34 with SMTP id bt2mr602335pad.3.1383099424135; Tue, 29 Oct 2013 19:17:04 -0700 (PDT) Received: from pyunyh@gmail.com ([114.111.62.249]) by mx.google.com with ESMTPSA id xe9sm978426pab.0.2013.10.29.19.17.00 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 29 Oct 2013 19:17:02 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Wed, 30 Oct 2013 11:16:50 +0900 From: Yonghyeon PYUN Date: Wed, 30 Oct 2013 11:16:50 +0900 To: Boris Samorodov Subject: Re: regression: msk0 watchdog timeout and interrupt storm Message-ID: <20131030021650.GA3106@michelle.cdnetworks.com> References: <526FBA53.9000208@passap.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <526FBA53.9000208@passap.ru> User-Agent: Mutt/1.4.2.3i Cc: FreeBSD Stable Users X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 02:17:05 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 29, 2013 at 05:38:27PM +0400, Boris Samorodov wrote: > Hi Yonghyeon and All, > Hi, > >From time to time I use a notebook and boot FreeBSD from USB > stick. FreeBSD 9.2-i386 works OK. So I tried to use > FreeBSD 10.0-i386 BETA2 and the network adapter works for > some 10-15 seconds and then stops with diagnostic message > "msk0:watchdog timeout". I've found similar case at > freebsd-current@ with no workaround. Yes, there is an > interrupt storm as well. There had been no functional changes for very long time so I'm not sure what's going on here. I've attached local change I have at this moment but I'm afraid it wouldn't address the issue above. I recall jhb also reported interrupt storm in the past but the root cause was not identified yet. Could you change msk_intr() and let me know which interrupt is firing? > > Here is some additional info: > ----- > mskc0@pci0:3:0:0: class=0x020000 card=0xff501179 chip=0x435511ab > rev=0x12 hdr=0x00 > vendor = 'Marvell Technology Group Ltd.' > device = '88E8040T PCI-E Fast Ethernet Controller' > class = network > subclass = ethernet > cap 01[48] = powerspec 3 supports D0 D1 D2 D3 current D0 > cap 05[5c] = MSI supports 1 message, 64 bit enabled with 1 message > cap 10[c0] = PCI-Express 2 legacy endpoint max data 128(128) link x1(x1) > speed 2.5(2.5) ASPM disabled(L0s/L1) > ecap 0001[100] = AER 1 0 fatal 0 non-fatal 1 corrected > ecap 0003[130] = Serial 1 b8b063ffff681e00 > ----- > > -- > WBR, Boris Samorodov (bsam) > FreeBSD Committer, http://www.FreeBSD.org The Power To Serve --HcAYCG3uE/tztfnV Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="msk.link.diff" Index: sys/dev/msk/if_msk.c =================================================================== --- sys/dev/msk/if_msk.c (revision 257303) +++ sys/dev/msk/if_msk.c (working copy) @@ -4071,12 +4071,12 @@ CSR_WRITE_4(sc, B0_IMSK, sc->msk_intrmask); CSR_READ_4(sc, B0_IMSK); + ifp->if_drv_flags |= IFF_DRV_RUNNING; + ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; + sc_if->msk_flags &= ~MSK_FLAG_LINK; mii_mediachg(mii); - ifp->if_drv_flags |= IFF_DRV_RUNNING; - ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; - callout_reset(&sc_if->msk_tick_ch, hz, msk_tick, sc_if); } --HcAYCG3uE/tztfnV--