From owner-freebsd-net Wed Nov 6 8:30:13 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 619ED37B401 for ; Wed, 6 Nov 2002 08:30:12 -0800 (PST) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9304C43E3B for ; Wed, 6 Nov 2002 08:30:11 -0800 (PST) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id IAA42961; Wed, 6 Nov 2002 08:19:39 -0800 (PST) Received: from arch20m.dellroad.org (localhost [127.0.0.1]) by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id gA6GJasb002594; Wed, 6 Nov 2002 08:19:36 -0800 (PST) (envelope-from archie@arch20m.dellroad.org) Received: (from archie@localhost) by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id gA6GJZ93002593; Wed, 6 Nov 2002 08:19:35 -0800 (PST) From: Archie Cobbs Message-Id: <200211061619.gA6GJZ93002593@arch20m.dellroad.org> Subject: Re: NFS functions does *NOT* check if they really have allocated any memory In-Reply-To: <20021106125444.K20974-100000@beagle.fokus.gmd.de> "from Harti Brandt at Nov 6, 2002 12:56:13 pm" To: Harti Brandt Date: Wed, 6 Nov 2002 08:19:35 -0800 (PST) Cc: Iasen Kostov , Archie Cobbs , freebsd-net@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL88 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Harti Brandt writes: > IK>> > As I experience system crushes at time of mbufs exhaustion I've compiled > IK>> > a debug kernel and traced the problem. I seems the NFS functions > IK>> > (nfsm_rpchead, nfsm_reqh ...) does *NOT* chek if they really have > IK>> > allocated memory by MGET macro. > IK>> > IK>> No check is necessary if M_WAIT is specified; the M_GET() function > IK>> is always successful in that case. Same for malloc(). > > Wrong. malloc() returns always successful with M_WAIT, M_GET not. There > is a timeout the M_GET() will wait, but the it will return NULL. Oops, you're right.. sorry for the misinformation. Sounds like a bug to me (did Iasen file a PR?) -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message