From owner-freebsd-multimedia Tue Feb 3 10:32:36 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA09667 for freebsd-multimedia-outgoing; Tue, 3 Feb 1998 10:32:36 -0800 (PST) (envelope-from owner-freebsd-multimedia@FreeBSD.ORG) Received: from gratis.grondar.za (gratis.grondar.za [196.7.18.133]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA09659 for ; Tue, 3 Feb 1998 10:32:32 -0800 (PST) (envelope-from mark@greenpeace.grondar.za) Received: from greenpeace.grondar.za (greenpeace.grondar.za [196.7.18.132]) by gratis.grondar.za (8.8.8/8.8.8) with ESMTP id UAA10738; Tue, 3 Feb 1998 20:31:34 +0200 (SAST) (envelope-from mark@greenpeace.grondar.za) Received: from greenpeace.grondar.za (localhost [127.0.0.1]) by greenpeace.grondar.za (8.8.8/8.8.8) with ESMTP id UAA25042; Tue, 3 Feb 1998 20:31:33 +0200 (SAST) (envelope-from mark@greenpeace.grondar.za) Message-Id: <199802031831.UAA25042@greenpeace.grondar.za> X-Mailer: exmh version 2.0.1 12/23/97 To: Luigi Rizzo cc: multimedia@FreeBSD.ORG, hasty@rah.star-gate.com Subject: Re: bt848 feedback... Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Feb 1998 20:31:33 +0200 From: Mark Murray Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe freebsd-multimedia" Luigi Rizzo wrote: > In the latest release of the Bt848 code, I noticed the BT848_I2CWR > ioctl that I submitted some time ago has been put in video_ioctl(), > but it really belongs in tuner_ioctl() , where other I2C devices are > also accessed. Dammit. My fault. Sorry. > It's just a matter of moving the block in the other function (and > moving the variable declarations at the beginning of video_ioctl, > a hundred lines above... what was wrong with declaring variables > within the block they are used, as in the patch I submitted!). Please try to keep your coding style consistent with the existing code. There is nothing technically wrong with having the variables in the place you put them; however > > Oh btw the code works perfectly on 2.2.1 > > cheers > luigi > -----------------------------+-------------------------------------- > Luigi Rizzo | Dip. di Ingegneria dell'Informazione > email: luigi@iet.unipi.it | Universita' di Pisa > tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) > fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ > _____________________________|______________________________________ -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org