From nobody Tue Apr 16 20:13:52 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VJwGm4nxKz5H0lh for ; Tue, 16 Apr 2024 20:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VJwGm1ZJnz3wdP for ; Tue, 16 Apr 2024 20:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713298432; a=rsa-sha256; cv=none; b=KsmCdZzt5KbX+dlSUQE71CgNwJlaCs91KxD9736XHceYtCoEwvH6EAzrbmTQl/xY4mP9b0 EbttvHlmffo5Z8C3mB6JjcdEjV3S9KN//lv9ZUUF7PbZwD9NnAEi90W+YKfHIM8BV00Jal 8OjYE2edSQI7JxShbXQkobyctzEKQy3aiVXWNmSk0xtvVR/S6S1CKW/9BsCDVTvicGQ7LR 2HoWDaUeW+VxOjy3HfbWjBICxxWi4gLepnyaPQkhLfW9TLsI/en6CUuqahj0nAc7Vfcp/W HGeL2LYHIA8kw1HSheYs3/Jq2J/wjjzAmhIQGy+uH7pzS6FcVIxOWxFUSggnyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/IVyhEUhyczyGPY7f8HFLnPu8C3DJpnb5T5YdlIODo=; b=Az7OItvDmV7Il9wjBL6rfYT9xNDUAzFbkf4KzA/5lc+ugjc9FkEZ0nBV6Q53djRbXt7JaK yTPADqNpeytVBjekc3jdlUn9OYvLefBSW+KVaCFeZdns2foInyk/1jWp/XYHFOtPa2V2sY bRF5Q4ODgK0ze1Cs75KlSgod/L0sp/wX6JijB9JA8o+YabBa9lNUiNgZwbhgnzgDsse959 ZahPu/027W0sIzh9hRsljYTcdrPuYKF9BAfjCdWOE4zbg2REdlo4YqfQQ5Wkwd2rV2lCI1 i7d9/dMq8IVhkzBFvFhK1HRyuR8qYGAWxfo3qDQjWfqqVMtVgGvmC4FobmPQ/w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VJwGm18YpzwwH for ; Tue, 16 Apr 2024 20:13:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 43GKDqet091857 for ; Tue, 16 Apr 2024 20:13:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 43GKDqB0091852 for bugs@FreeBSD.org; Tue, 16 Apr 2024 20:13:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 275965] periodic: add a daily zfs trim Date: Tue, 16 Apr 2024 20:13:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275965 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D3e69ab88a032ac43d433f787b715466a8= 7e72817 commit 3e69ab88a032ac43d433f787b715466a87e72817 Author: Lexi Winter AuthorDate: 2024-04-09 21:49:56 +0000 Commit: Warner Losh CommitDate: 2024-04-16 19:54:20 +0000 periodic/daily/801.trim-zfs: Add a daily zfs trim script As mentioned in zpoolprops(7), on some SSDs, it may not be desirable to use ZFS autotrim because a large number of trim requests can degrade disk performance; instead, the pool should be manually trimmed at regular intervals. Add a new daily periodic script for this purpose, 801.trim-zfs. If enabled (daily_trim_zfs_enable=3DYES; the default is NO), it will run a 'zpool trim' operation on all online pools, or on the pools listed in 'daily_trim_zfs_pools'. The trim is not started if the pool is degraded (which matches the behaviour of the existing 800.scrub-zfs script) or if a trim is already running on that pool. Having autotrim enabled does not inhibit the periodic trim; it's sometimes desirable to run periodic trims even with autotrim enabled, because autotrim can elide trims for very small regions. PR: 275965 MFC after: 1 week Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/956 (cherry picked from commit 493908c4b45c7b75e4a6b4aea3b5b63ea5c268d5) share/man/man5/periodic.conf.5 | 11 ++++- usr.sbin/periodic/etc/daily/801.trim-zfs (new +x) | 59 +++++++++++++++++++= ++++ usr.sbin/periodic/etc/daily/Makefile | 3 +- usr.sbin/periodic/periodic.conf | 5 ++ 4 files changed, 76 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=