Date: Thu, 15 Jun 2017 01:56:35 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: "Tobias C. Berner" <tcberner@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443599 - head/Mk Message-ID: <20170615015635.GA78699@FreeBSD.org> In-Reply-To: <2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94@adamw.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org> <20170615005515.GA26393@FreeBSD.org> <2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 14, 2017 at 07:44:49PM -0600, Adam Weinberger wrote: > > On 14 Jun, 2017, at 18:55, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > On Wed, Jun 14, 2017 at 08:18:38PM +0000, Tobias C. Berner wrote: > >> New Revision: 443599 > >> URL: https://svnweb.freebsd.org/changeset/ports/443599 > >> > >> Log: > >> Add note, that WRKDIRPREFIX must not end in '/'. > >> > >> PR: 199297 > > > > This is stupid, fragile, error-prone appoach that does not even cover all > > cases (like shown in the PR) when no paths end in slash but the problem > > still occurs. Did you read the analysis of my original problem carefully > > enough? It was not about slashes, it was symlinks and realpath. > > > > You might not like proposed solution but then think of something better; > > computers are smart enough to handle slashes automagically rather than > > depend on that unrealiable human beings will follow the rules and notes. > > Okay, but WRKDIRPREFIX still shouldn't end in a slash though, and a > comment saying not to put a slash at the end is a pretty reasonable move. Oh I don't mind the comment (esp. that I'm not a big fan of superfluous slashes appended to directories), but was somewhat disappointed that my PR was closed as WONTFIX (works as intended) with no response to analysis of the problem, no discussion of the proposed solution, etc. All the effor was flushed down the toilet. Needless to say, the problem is still there until someone else trips on it and opens a similar PR. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170615015635.GA78699>