Date: Sun, 17 May 2020 18:50:51 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 246529] devel/binaryen: Update 90 -> 93 Message-ID: <bug-246529-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246529 Bug ID: 246529 Summary: devel/binaryen: Update 90 -> 93 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: bethanylong.x90@gmail.com CC: greg@unrelenting.technology Flags: maintainer-feedback?(greg@unrelenting.technology) CC: greg@unrelenting.technology Really we just need 91+. Current emscripten expects a new wasm-opt --version format, which prevents new users (like me) from building their hello worlds: % emcc -o hello.html hello.c cache:INFO: generating system asset: generated_struct_info.json... (this wi= ll be cached in "/home/username/.emscripten_cache/wasm/generated_struct_info.j= son" for subsequent builds) shared:ERROR: error parsing binaryen version (wasm-opt 90). Please check yo= ur binaryen installation (/usr/local/bin/wasm-opt) FAIL: Compilation failed! % wasm-opt --version wasm-opt 90 This is the format it expects: % wasm-opt --version wasm-opt version 93 This is where upstream binaryen changed the --version format: https://github.com/WebAssembly/binaryen/commit/4953bcc59085c49343c334ccc852= fc5c0339c938#diff-0cdf1402e4de0d0e0a450c4f5558d589 This is where emscripten started expecting three tokens in wasm-opt's --ver= sion output: https://github.com/emscripten-core/emscripten/commit/4fdb3053690170362c5f7c= 83a553149c8956d3c2#diff-b97059c38de7432017d59dee3e87bc72 --- Using previous upgrades (bug 238994, bug 243308) as a cheat sheet, to insta= ll version 93 locally I updated DISTVERSION in the Makefile and distinfo, and removed the patch in files/. Upstream version 93 seems to gate the git check natively now, so I don't think our patch is required anymore. % grep 93 * distinfo:SHA256 (WebAssembly-binaryen-version_93_GH0.tar.gz) =3D a770a26dea4da4b33eee4a020f054196e9530cceeeff17b977e2bc6e4fd2dd7f distinfo:SIZE (WebAssembly-binaryen-version_93_GH0.tar.gz) =3D 4244359 Makefile:DISTVERSION=3D 93 % ls files % Also, it doesn't look like there need to be any pkg-plist changes: /usr/ports/devel/binaryen/work/.build% diff -u ../../pkg-plist <(find bin l= ib -type f | sort) --- ../../pkg-plist 2019-07-06 11:08:27.000000000 -0700 +++ /tmp/zshrTNFvh 2020-05-17 11:40:41.263302000 -0700 @@ -8,5 +8,4 @@ bin/wasm-reduce bin/wasm-shell bin/wasm2js -include/binaryen-c.h lib/libbinaryen.so --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-246529-7788>