From owner-freebsd-python@FreeBSD.ORG Tue May 12 19:33:28 2015 Return-Path: Delivered-To: python@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DC64EF0F for ; Tue, 12 May 2015 19:33:28 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C6EBE1C6B for ; Tue, 12 May 2015 19:33:28 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4CJXS2F027688 for ; Tue, 12 May 2015 19:33:28 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 199838] [NEW PORT] games/pyfa fitting tool for EVE Online Date: Tue, 12 May 2015 19:33:28 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: amdmi3@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: amdmi3@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 19:33:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199838 Dmitry Marakasov changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-ports-bugs@FreeBSD. |amdmi3@FreeBSD.org |org | CC| |amdmi3@FreeBSD.org Status|New |In Progress --- Comment #2 from Dmitry Marakasov --- - GH_COMMIT is deprecated and no longer needed. You should omit GH_COMMIT, GH_TAGNAME and WRKSRC and add DISTVERSIONSUFFIX=v, this way it'll fetch v${PORTVERSION} tag - You should use COPYTREE_SHARE instead of manual find's - Only uppercase option names are allowed - Option description is misleading, should probably be reworded - It seems to be a bad idea to stick data files into PYTHON_SITELIBDIR. You may use default DATADIR and set PYTHONPATH in the wrapper script - Wrapper script creating fits more into post-build - do-install and post-install may be merged, there's not need to split them - compileall is usually called twice, second time with -O arg to generate *.pyo. Propaply this port should do the same - Since plist is quite large, it's better to use PORTDATA=* and omit %%DATADIR%%* from plist - DATADIR contents will be added automatically this way -- You are receiving this mail because: You are on the CC list for the bug.