From owner-svn-src-all@FreeBSD.ORG Wed May 27 11:12:21 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9081681C; Wed, 27 May 2015 11:12:21 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F35A4C9D; Wed, 27 May 2015 11:12:20 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t4RBCGXS095574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 27 May 2015 14:12:16 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t4RBCGX7095573; Wed, 27 May 2015 14:12:16 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 27 May 2015 14:12:16 +0300 From: Gleb Smirnoff To: Adrian Chadd Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r283568 - head/sys/net80211 Message-ID: <20150527111216.GD73119@FreeBSD.org> References: <201505261319.t4QDJ5Hj045298@svn.freebsd.org> <20150526154453.GA73119@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 11:12:21 -0000 On Tue, May 26, 2015 at 11:25:32AM -0700, Adrian Chadd wrote: A> On 26 May 2015 at 08:44, Gleb Smirnoff wrote: A> > On Tue, May 26, 2015 at 08:25:01AM -0700, Adrian Chadd wrote: A> > A> Hi, A> > A> A> > A> We're going to have to move all of the counter API stuff into A> > A> ieee80211_freebsd.[ch]. A> > A> > Well, I put the function in the same file where if_get_counter pointer A> > is set, so that it can be static. You need distinctive border between A> > FreeBSD and non-FreeBSD stuff, which right now isn't yet clear. A> > A> > I don't mind moving, but looks like the ifnet attachment process, either A> > the current one or the future one, also needs to be moved to FreeBSD A> > part of the code. A> A> Yeah, the lines got .. blurred. I don't want to go full portability A> unless someone comes up with a very pressing need - eg, still assume A> ifnet ,still assume ioctl ,transmit/start, receive, mbufs, etc. But A> vnets and counter API should be easy to migrate out so A> netbsd/dragonflybsd can port things. Well, that's a good stuff to do goodness to others (Net/DragonFly), but in these two particular cases (vnet/counter), they can deal with the problem theirselves much easier: typedef counter_u64_t u_int #define counter_u64_add(foo) foo++ #define CURVNET_SET(foo) do {} while (0); #define CURVNET_RESTORE() do {} while (0); , than us modifing all the net80211 for the sake of hiding these APIs. -- Totus tuus, Glebius.