From owner-cvs-all Sat Mar 8 23:46:48 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 948F837B405 for ; Sat, 8 Mar 2003 23:46:45 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 41E3F43FE1 for ; Sat, 8 Mar 2003 23:46:41 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 91317 invoked by uid 1000); 9 Mar 2003 07:46:43 -0000 Date: Sat, 8 Mar 2003 23:46:43 -0800 (PST) From: Nate Lawson To: Poul-Henning Kamp Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha autoconf.c src/sys/cam cam_periph.h cam_xpt.c src/sys/cam/scsi scsi_da.c scsi_low.c scsi_ses.c src/sys/contrib/dev/fla fla.c src/sys/dev/aac aac.c aac_cam.c aac_debug.c aac_disk.c aac_pci.c aacvar.h ... In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Saturday, Mar 8, 2003, at 03:01 US/Eastern, Poul-Henning Kamp wrote: > > > phk 2003/03/08 00:01:31 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/alpha/alpha autoconf.c > > [...] > > Log: > > Centralize the devstat handling for all GEOM disk device drivers > > in geom_disk.c. > > > > As a side effect this makes a lot of #include > > lines not needed and some biofinish() calls can be reduced to > > biodone() again. In cam/scsi/scsi_da.c, please explain to me why you have removed all checking of the DEVSTAT_BS_UNAVAILABLE flag as well as comments explaining why this is useful. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message