From owner-svn-ports-head@freebsd.org Sat Aug 3 09:02:39 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 541F2ABF5F; Sat, 3 Aug 2019 09:02:39 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 460yjC1Y2Kz45VN; Sat, 3 Aug 2019 09:02:39 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1664818C2C; Sat, 3 Aug 2019 09:02:39 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x7392c1M061916; Sat, 3 Aug 2019 09:02:38 GMT (envelope-from tobik@FreeBSD.org) Received: (from tobik@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x7392cKh061915; Sat, 3 Aug 2019 09:02:38 GMT (envelope-from tobik@FreeBSD.org) Message-Id: <201908030902.x7392cKh061915@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: tobik set sender to tobik@FreeBSD.org using -f From: Tobias Kortkamp Date: Sat, 3 Aug 2019 09:02:38 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r507940 - head/databases/pg_reorg X-SVN-Group: ports-head X-SVN-Commit-Author: tobik X-SVN-Commit-Paths: head/databases/pg_reorg X-SVN-Commit-Revision: 507940 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Aug 2019 09:02:39 -0000 Author: tobik Date: Sat Aug 3 09:02:38 2019 New Revision: 507940 URL: https://svnweb.freebsd.org/changeset/ports/507940 Log: databases/pg_reorg: Do not build on newer PostgreSQL versions It fails to build with PostgreSQL 11: pgut/pgut.c:389:47: error: too few arguments to function call, expected 4, have 3 return simple_prompt("Password: ", 100, false); ~~~~~~~~~~~~~ ^ /usr/local/include/postgresql/server/port.h:193:1: note: 'simple_prompt' declared here extern void simple_prompt(const char *prompt, char *destination, size_t destlen, ^ 1 error generated. http://package18.nyi.freebsd.org/data/120amd64-default-PR239514/2019-07-29_20h41m52s/logs/pg_reorg-1.1.11_2.log And after fixing that one: reorg.c:230:55: warning: incompatible pointer types passing 'bool [1]' to parameter of type 'const char *' [-Wincompatible-pointer-types] execute_plan(SPI_OK_SELECT, plan_peek, values_peek, nulls_peek); ^~~~~~~~~~ ./pgut/pgut-spi.h:28:84: note: passing argument to parameter 'nulls' here extern void execute_plan(int expected, SPIPlanPtr plan, Datum *values, const char *nulls); ^ reorg.c:256:58: warning: incompatible pointer types passing 'bool *' to parameter of type 'const char *' [-Wincompatible-pointer-types] execute_plan(SPI_OK_INSERT, plan_insert, &values[2], &nulls[2]); ^~~~~~~~~ [...] reorg.c:573:34: error: use of undeclared identifier 'BTREE_AM_OID' opclass = OpclassnameGetOpcid(BTREE_AM_OID, opcname); ^ reorg.c:590:57: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'? opcintype = RelationGetDescr(indexRel)->attrs[nattr]->atttypid; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ etc. PR: 239514 Modified: head/databases/pg_reorg/Makefile Modified: head/databases/pg_reorg/Makefile ============================================================================== --- head/databases/pg_reorg/Makefile Sat Aug 3 09:02:25 2019 (r507939) +++ head/databases/pg_reorg/Makefile Sat Aug 3 09:02:38 2019 (r507940) @@ -24,8 +24,14 @@ PORTDOCS= * OPTIONS_DEFINE= DOCS +.include + +.if ${PGSQL_VER:R} >= 11 +IGNORE= incompatible with PostgreSQL 11 or newer +.endif + post-install: @${MKDIR} ${STAGEDIR}${DOCSDIR} (cd ${WRKSRC}/doc && ${COPYTREE_SHARE} . ${STAGEDIR}${DOCSDIR}) -.include +.include