Date: Tue, 10 Jan 2006 05:08:28 +0800 From: Ariff Abdullah <ariff@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: freebsd-acpi@FreeBSD.org, freebsd-amd64@FreeBSD.org, lists@stringsutils.com Subject: Re: No APM yet for AMD? Message-ID: <20060110050828.100b026a.ariff@FreeBSD.org> In-Reply-To: <43C2C6AB.5060605@root.org> References: <cone.1135611096.296999.80599.1000@zoraida.natserv.net> <63675.24.71.129.36.1135718125.squirrel@imap.sd73.bc.ca> <cone.1135784510.758843.3324.1000@zoraida.natserv.net> <200512291412.19476.peter@wemm.org> <cone.1136052558.494842.28540.1000@zoraida.natserv.net> <20060103155509.GE13887@poupinou.org> <cone.1136308365.970162.45107.1000@zoraida.natserv.net> <20060103185047.GH13887@poupinou.org> <cone.1136387653.168993.62674.1000@zoraida.natserv.net> <20060104161842.GK13887@poupinou.org> <20060105005441.029835c1.ariff@FreeBSD.org> <43C2C6AB.5060605@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Tue__10_Jan_2006_05_08_28_+0800_gn3.GgUx4JRSvk8o
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, 09 Jan 2006 12:25:15 -0800
Nate Lawson <nate@root.org> wrote:
>=20
> I looked at the patch but had a hard time figuring out what the=20
> functional changes are. Most of the changes are just using a=20
> convenience pointer to see the struct members and some style=20
> misformatting of the printf arguments. (The second line of
> indentation needs to be 4 spaces indented, see style(9)).
>=20
> What part of this patch is just the functional change?
>=20
There are no functional changes at all. It simply trying to be more
verbose (and forgiving), in case the ioctl did not return advance
information (such as remaining time, so on) which I believe few ACPI
bioses incapable of providing such info. In this case, it trying to
calculate the percentage of remining battery capacity based on Last
Full Capacity, which current acpiconf ignore.
# acpiconf -i 0 (without patch)
Design capacity: 6000 mAh
Last full capacity: 4000 mAh
Technology: secondary (rechargeable)
Design voltage: 14800 mV
Capacity (warn): 207 mAh
Capacity (low): 125 mAh
Low/warn granularity: 10 mAh
Warn/full granularity: 25 mAh
Model number: JM-6
Serial number: 0046713127
Type: LION
OEM info: Hewlett-Packard
State: not present
^^^^^^^^^^^
Voltage: unknown
# acpiconf -i 0 (patched)
Design capacity: 6000 mAh
Last full capacity: 4000 mAh
Technology: secondary (rechargeable)
Design voltage: 14800 mV
Capacity (warn): 207 mAh
Capacity (low): 125 mAh
Low/warn granularity: 10 mAh
Warn/full granularity: 25 mAh
Model number: JM-6
Serial number: 0046713127
Type: LION
OEM info: Hewlett-Packard
State: high=20
^^^^
Present rate: unknown
Remaining capacity: 100%
^^^^
Voltage: unknown
AC line: on-line
--
Ariff Abdullah
FreeBSD
--Signature=_Tue__10_Jan_2006_05_08_28_+0800_gn3.GgUx4JRSvk8o
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDwtDQlr+deMUwTNoRAj1bAJ9sTNnUffo5p42gGDsXzN3XNJTLNgCff63Z
kGJ8hceAVphV16h1edQRpnY=
=SJhn
-----END PGP SIGNATURE-----
--Signature=_Tue__10_Jan_2006_05_08_28_+0800_gn3.GgUx4JRSvk8o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060110050828.100b026a.ariff>