Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 13 Aug 2015 16:10:04 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 202295] usr/src/sbin/ipfw/dummynet.c:1306: bad if test ?
Message-ID:  <bug-202295-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202295

            Bug ID: 202295
           Summary: usr/src/sbin/ipfw/dummynet.c:1306: bad if test ?
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: misc
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

[usr/src/sbin/ipfw/dummynet.c:1306]: (style) Same expression on both sides of
'||'.

Source code is

        if (v[1] < v[0] ||
            v[1] >= DN_MAX_ID-1 ||
            v[1] >= DN_MAX_ID-1) {
            continue; /* invalid entry */

Maybe

        if (v[1] < v[0] ||
            v[0] >= DN_MAX_ID-1 ||
            v[1] >= DN_MAX_ID-1) {
            continue; /* invalid entry */

-- 
You are receiving this mail because:
You are the assignee for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202295-8>