Date: Mon, 08 Apr 2002 08:17:33 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/newfs mkfs.c newfs.c newfs.h Message-ID: <54697.1018246653@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 08 Apr 2002 15:56:18 %2B1000." <20020408154911.F5774-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020408154911.F5774-100000@gamplex.bde.org>, Bruce Evans writes: >On Sun, 7 Apr 2002, Poul-Henning Kamp wrote: > >> phk 2002/04/07 07:57:57 PDT >> >> Modified files: >> sbin/newfs mkfs.c newfs.c newfs.h >> Log: >> bbsize and sbsize cannot ever be trusted from the disklabel, in >> particular as there may not be one. Remove #if 0'ed code which might >> mislead people to think otherwise. > >I use this code unconditionally. bbsize and sbsize from the disklabel >can be trusted in all cases that I know of (if there is a disklabel). > >Please back this out. I don't intend to. newfs will have to learn the new (not yet committed) API just like any other program. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54697.1018246653>