Date: Sun, 1 Apr 2007 20:14:51 -0600 From: "Coleman Kane" <zombyfork@gmail.com> To: "=?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?=" <des@des.no> Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Kris Kennaway <kris@freebsd.org>, cvs-all@freebsd.org, Colin Percival <cperciva@freebsd.org>, Kostik Belousov <kostikbel@gmail.com> Subject: Re: cvs commit: src/sys/pci if_vr.c Message-ID: <346a80220704011914h4bcf13e4wfffc21ec52c4d38@mail.gmail.com> In-Reply-To: <86slbkxsvm.fsf@dwp.des.no> References: <20070401070403.16724517E2@repoman.freebsd.org> <20070401091501.GK18105@deviant.kiev.zoral.com.ua> <460F8299.20307@freebsd.org> <86slbkxsvm.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/1/07, Dag-Erling Sm=F8rgrav <des@des.no> wrote: > > Colin Percival <cperciva@freebsd.org> writes: > > Judging by what I see at http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/= , > > it looks like everything has been reverted now, so hopefully Kris can g= o > > ahead and redo his original commit later today without any of the > changes > > which slipped in by mistake. > > Great! I have a megapatch lined up as well. In the spirit of > sustainable kernel development, atomic operations are being renamed to > renewable operations. > > DES > -- > Dag-Erling Sm=F8rgrav - des@des.no > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > I think that I may just have to start a thread to protest your renewable operations patch. The naming conventions used in the new macros unnecessarily stick out under review of the source code where they are implemented, thus overshadowing and blocking out my abilities to inspect less prominent features in the code where they are used. I think that these aesthetic concerns in this situation override any possible gains through reduction in operation waste, and the changes should be reconsidered under these grounds. In addition, I (and others) fear that these renewable operations will render the development of devel/liboil obsolete, and its developers unemployed. -- Coleman Kane
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?346a80220704011914h4bcf13e4wfffc21ec52c4d38>