Date: Sat, 13 Jun 2015 10:48:47 -0400 From: Warner Losh <imp@bsdimp.com> To: Julian Elischer <julian@FreeBSD.org> Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>, Alexander Kabaev <kabaev@gmail.com>, Marcel Moolenaar <marcel@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284198 - head/bin/ls Message-ID: <5918EB58-8E32-4D03-87BB-90AF5DA97E36@bsdimp.com> In-Reply-To: <557C3D9D.5050905@freebsd.org> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <557C3D9D.5050905@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Jun 13, 2015, at 10:26 AM, Julian Elischer <julian@FreeBSD.org> = wrote: >=20 > On 6/13/15 10:49 AM, Steve Kargl wrote: >> On Fri, Jun 12, 2015 at 08:43:09PM -0400, Alexander Kabaev wrote: >>> On Wed, 10 Jun 2015 01:27:39 +0000 (UTC) >>> Marcel Moolenaar <marcel@FreeBSD.org> wrote: >>>=20 >>>> Author: marcel >>>> Date: Wed Jun 10 01:27:38 2015 >>>> New Revision: 284198 >>>> URL: https://svnweb.freebsd.org/changeset/base/284198 >>>>=20 >>>> Log: >>>> Convert ls(1) to use libxo(3). >>>> Obtained from: Phil Shafer <phil@juniper.net> >>>> Sponsored by: Juniper Networks, Inc. >>>>=20 >>> <SKIP> >>>=20 >>> This broke all code that pipes output of the ls command to pipeline, >>> such as 'ls | wc -l'. ls never exits and never output anything. Is >>> there any purpose to libxo other than breaking stuff, which it = achieves >>> so splendidly? >>>=20 >> -1 for libxo, which also makes code almost unreadable. > +1 of the -1 >=20 > my personal vote is to revert all libxo changes and banish it from = /usr/src. >=20 > "not the way to solve the problem in question". It isn=92t even wrong=85. I think that we shouldn=92t integrate any more libxo stuff until all the = known bugs in the stuff that=92s already been converted is fixed. For example, gstat=92s =91q=92 function now needs a <bleeping> carriage = return before it will quit. That=92s insane. And the twisty maze of = modifications has made it rather an uber-pita to figure out WTF I need to do to un-F this up. But back to the topic at hand. libxo for ls? Really? WTF were you thinking? I know the cat -v paper is a bit of an extreme viewpoint, but all the libxo integration can be used a poster child for Pike=92s worries=85 Warner --Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVfELQAAoJEGwc0Sh9sBEAOjUP/24BvZ9SJcpDS67Nun3RqpSH FBPLryJnEoMimCKbuEqMdyqeIJrUePGIunzCo0qdXn5wUlFcJN9aCnm0//Pt5w5D qGJY/KIvD1pPXCyOEoku+p7SE4dOZzQje5vFQ5BnThW+r5Ptz04OqvCnSO9BaQ5E nvB/hYajXrqKrz8fACkTQxrMpiELWItShIFqRUGNP5IehwwzPwo/4UHcNobhNYNq rjXl6oqzPtWhQpbLkQuDqCkCICuTFlkuF2sn2p3XwKU2p0xQpJu9AaWMvp73fObM TWr0kdl6NYkZOmqgjpDVwlUYQD4v2VVz/bmM70g17CvvwP/ZervxrkfbQhB8Nt69 cOby2XiqBX6QpYHtSh7cJSFobftApfjZBgRoKPqIVd+34mGu967tkgPZ2A04wXFp QIS+ncr5gCppwCEK6IYAM/xiBI5sNjI0V0GUk7WwX1a93bPmCoLNYwCrDDgHGNdd XsmMYpNZ5QRCIWGgTjj8MuhbL0Mbm8t6fowdlmh9RpxvqgRGixuRYtk695qETxGW rlBum2ni43heSnPR2j2zUDKQghFrEfleWldIxdVQHGiKBoJ2w9eT++xPrcVuEScz 6Rixc70JRS2NiETpEV4lfdRMi6hb/5bOOPY3v3mARvFsi3qbDV9pGhb2DEuz4gP+ dZ2Vn6/VSBdD7lF6wML+ =lxiN -----END PGP SIGNATURE----- --Apple-Mail=_E3E519E8-B16C-4D16-A02D-7012F9FBB686--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5918EB58-8E32-4D03-87BB-90AF5DA97E36>