From owner-freebsd-arch@FreeBSD.ORG Mon May 5 14:21:02 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1DFD51065670; Mon, 5 May 2008 14:21:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay03.kiev.sovam.com (relay03.kiev.sovam.com [62.64.120.201]) by mx1.freebsd.org (Postfix) with ESMTP id AC8478FC17; Mon, 5 May 2008 14:21:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay03.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1Jt1Yp-000Hg3-FA; Mon, 05 May 2008 17:21:00 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m45EKuLv063904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 May 2008 17:20:56 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m45EKqdT009653; Mon, 5 May 2008 17:20:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m45EKpu0009652; Mon, 5 May 2008 17:20:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 5 May 2008 17:20:51 +0300 From: Kostik Belousov To: John Baldwin Message-ID: <20080505142051.GS18958@deviant.kiev.zoral.com.ua> References: <20080504171002.GN18958@deviant.kiev.zoral.com.ua> <200805050939.42425.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vb/P15UJLYd8hx0q" Content-Disposition: inline In-Reply-To: <200805050939.42425.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 717fb1dce93df3d9117221529acf11a8 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2780 [May 05 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: freebsd-arch@freebsd.org Subject: Re: Per-open file private data for the cdevs X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2008 14:21:02 -0000 --vb/P15UJLYd8hx0q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 05, 2008 at 09:39:42AM -0400, John Baldwin wrote: > On Sunday 04 May 2008 01:10:02 pm Kostik Belousov wrote: > > Since the review for the clone-at-open patch (fdclone) posted some time= ago > > mostly says that it would be better to implement per-file private data > > instead, I produced the patch along this line, > > > > The patch does not change the cdevsw ABI, instead, three new functions > > nt devfs_get_cdevpriv(void **datap); > > int devfs_set_cdevpriv(void *priv, cdevpriv_dtr_t dtr); > > void devfs_clear_cdevpriv(void); > > are provided for manipulation of the per-file private data. > > > > devfs_set_cdevpriv assigns the priv as private data for the file descri= ptor > > which is used to initiate currently performed driver operation. dtr > > is the function that will be called when either the last refernce to > > the file goes away or devfs_clear_cdevpriv is called. > > > > devfs_get_cdevpriv is the obvious accessor. > > > > devfs_clear_cdevpriv allows to clear the private data for the still > > open file. > > > > The synchronization of the cdev data and file private data is left > > to the driver code, I did not found any generic helper mechanism that > > could be useful there. > > > > Patch: > > http://people.freebsd.org/~kib/misc/fdpriv.1.patch > > > > Dumb driver that shows the basic usage of the proposed KPI: > > http://people.freebsd.org/~kib/misc/fpclone.c > > > > Previous version of the patch was tested by Peter Holm. >=20 > I like this very much and will use it instead of devfs cloning in ipmi(4)= so=20 > we can use ipmievd when it is committed. IWBN if there was a more automa= ted=20 > way of handling the unload race, for example if destroy_dev() could someh= ow=20 > clear all the per-open fd data. That may not be easily feasible, however= . =20 > (In theory each cdev could have a list of "attached" 'struct file' object= s=20 > that it updates in VOP_CLOSE() and for a destroy dev it detaches all the= =20 > private data after marking the cdev with a bad/null cdevsw, however, that= =20 > would bloat 'struct file' with at least one more pointer (if not two).) Probably, I shall clarify that the dtr is called when the last reference to the struct file going away, unless the priv data is already cleared by the call to the devfs_clear_cdevpriv. The problem with VOP_CLOSE() is that some actions (like forced unmount or revoke) may cause less calls to the devfs_close then the files pointing to the cdev. Your proposal basically means that we need, besides the normal pointers file->vnode->cdev, have the reverse path cdev->file. I think this is ugly and better be handled by the fdrop(). --vb/P15UJLYd8hx0q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkgfF8IACgkQC3+MBN1Mb4gqLwCg2slMEG4C9SK/IreydPLeJXu7 5a8AoOTYYIaq86Af9BRpmh/d91tz+RPp =/tM+ -----END PGP SIGNATURE----- --vb/P15UJLYd8hx0q--