Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Nov 2005 10:03:04 -0800
From:      Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
To:        Yar Tikhiy <yar@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/etc/rc.d hcsecd sdpd
Message-ID:  <bb4a86c70511181003y5a8d404bnf4cb0a68c6d4ed24@mail.gmail.com>
In-Reply-To: <20051118101729.GA87399@freefall.freebsd.org>
References:  <200511152036.jAFKaQMZ089811@repoman.freebsd.org> <20051118101729.GA87399@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Yar,

> > emax        2005-11-15 20:36:26 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     etc/rc.d             hcsecd sdpd
> >   Log:
> >   Revise hcsecd(8) and sdpd(8) rc.d scripts.
> >
> >   - Have both scripts automatically kldload ng_btsocket(4). I did not w=
ant to
> >     do it, but its easier for users and it seems other scripts do simil=
ar things;
>
> You need not override the start method for such a hack.
> Just put the kldload in the prestart method.

actually, i had to. i have defined sdpd_group and sdpd_user variables,
and, by default, run_rc_command() checks if ${name}_group and
${name}_user are defined and uses su(1) to start ${command}.

i guess, i could have used prestart and undefine  sdpd_group and
sdpd_user before calling run_rc_command().

> In addition, you could check if the module is loaded already.
> See the pf* scripts for an example.

well, yes, i could. but a saw a couple of bad examples in /etc/rc.d :)
that do it without checking. if it really bugs people, i could fix
this.

thanks,
max



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70511181003y5a8d404bnf4cb0a68c6d4ed24>