From owner-freebsd-bugs Wed Jan 15 11:18:44 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id LAA18167 for bugs-outgoing; Wed, 15 Jan 1997 11:18:44 -0800 (PST) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id LAA18134; Wed, 15 Jan 1997 11:18:19 -0800 (PST) Received: (from root@localhost) by dyson.iquest.net (8.8.4/8.6.9) id OAA00198; Wed, 15 Jan 1997 14:17:18 -0500 (EST) From: "John S. Dyson" Message-Id: <199701151917.OAA00198@dyson.iquest.net> Subject: Re: malloc(..., M_WAITOK) found harmful To: phk@critter.dk.tfs.com (Poul-Henning Kamp) Date: Wed, 15 Jan 1997 14:17:17 -0500 (EST) Cc: bde@zeta.org.au, dg@root.com, bugs@freebsd.org, dyson@freebsd.org, wollman@freebsd.org In-Reply-To: <28145.853355447@critter.dk.tfs.com> from "Poul-Henning Kamp" at Jan 15, 97 08:10:47 pm X-Mailer: ELM [version 2.4 PL24 ME8] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-bugs@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > In message <199701151754.EAA31434@godzilla.zeta.org.au>, Bruce Evans writes: > >> Arrg!!!! I didn't even know about "mcl_map". Okay, this is easy to fix - > >>mcl_map simply needs to be added to the list of maps in vm_map_entry_create. > > > >The maps are special-cased in too many other places. I added a check for > >mcl_map after all the relevant checks for mb_map in vm_map.c. It is also > >missing in vm_object.c. I think it is already handled right in vm_kern.c. > > Isn't it time to associate an attribute with the map, where we can see > this special casing, rather than have these if() statements get longer > and longer... ? > Yes. John