Date: Wed, 21 Jan 2015 22:21:02 -0700 From: Warner Losh <imp@bsdimp.com> To: Hans Petter Selasky <hps@selasky.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <19408675-1E2B-4F38-8C9A-66975B6C01DF@bsdimp.com> In-Reply-To: <54BE0528.2050503@selasky.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <CAJ-Vmok0GXZoojyi=jE=b5D-d338APztaf3Pw0_AAQ-173XSWw@mail.gmail.com> <54BDD9E1.6090505@selasky.org> <CAJ-VmokUJPzHqwjQT%2BRPh5afYbQnCAr1FdEUf_Z=_-OCg14ApQ@mail.gmail.com> <54BDE58F.3070909@selasky.org> <CAJ-VmomHUxRLfsBLNj_TBYS0sfZq0LgMM59hhy84E8pPwh3KpA@mail.gmail.com> <54BE0528.2050503@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 20, 2015, at 12:35 AM, Hans Petter Selasky <hps@selasky.org> = wrote: >=20 > On 01/20/15 06:22, Adrian Chadd wrote: >> Sweet, thanks. I'l test it, but anything that changes the locking to >> TCP is going to need a more thorough review. The "there be dragons" >> disclaimer is appropriate.:) >=20 > No changes in locking - simply some minor code reordering. This isn=E2=80=99t entirely true. You changed the INFO_WLOCK protocol, = and also drop the WLOCK to acquire the INFO_WLOCK in places, and it = isn=E2=80=99t clear to me at all why this is safe to do. Please document = the analysis you did to show that was safe. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19408675-1E2B-4F38-8C9A-66975B6C01DF>