From owner-svn-src-all@FreeBSD.ORG Thu Jan 22 05:21:06 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 049F470C for ; Thu, 22 Jan 2015 05:21:06 +0000 (UTC) Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB2748F1 for ; Thu, 22 Jan 2015 05:21:05 +0000 (UTC) Received: by mail-ob0-f180.google.com with SMTP id uz6so28526604obc.11 for ; Wed, 21 Jan 2015 21:21:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=1omhlkBVCJNTsDzPh+6hXMmwcOYHnQpTXCs8tTJKoEQ=; b=mgmC8rKFXFDL3BnRmXEuFfBhAagN7+Ptk987rp/n7UOZdCr3zfPAw5L3VHupvrw7gf LKzrV/p3+XlAVZF4SkeeZ5Pz+pO0EKc3ePqBoDhTz7ejYLViydQ62NG9P2Q7WTiZLFoX cQZYFJ0/aW0qirvRxnY+CN+LLJZazjSJ4uFu2AGXtf+ziFrQt8w2miPRlyW6MsJGNdhU 5j0r8uBUZDCnfVgKJ5l75LQFTdtqm7egy8xSLqAKtVrbnQHgmLGmI6Lpl1UzXeI8oT4+ 4fApOcuFMQWQujeOij/L1eFqundX1AbFVu4410b9nPoxQeV65wN4BNvONoKyjHKSK9Ma qP7Q== X-Gm-Message-State: ALoCoQn8ThVypO0CRRoMDOt51pe5mRPJ0kA+W9NISb8oAL3fC2ZJ1+Mu+eGRk29YSLIPVNxzu87T X-Received: by 10.182.148.98 with SMTP id tr2mr27417291obb.28.1421904064608; Wed, 21 Jan 2015 21:21:04 -0800 (PST) Received: from [192.168.43.169] ([172.56.8.11]) by mx.google.com with ESMTPSA id r9sm9021703obi.29.2015.01.21.21.21.03 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Jan 2015 21:21:04 -0800 (PST) Sender: Warner Losh Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys From: Warner Losh In-Reply-To: <54BE0528.2050503@selasky.org> Date: Wed, 21 Jan 2015 22:21:02 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <19408675-1E2B-4F38-8C9A-66975B6C01DF@bsdimp.com> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> <54BDE58F.3070909@selasky.org> <54BE0528.2050503@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.1993) Cc: "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 05:21:06 -0000 > On Jan 20, 2015, at 12:35 AM, Hans Petter Selasky = wrote: >=20 > On 01/20/15 06:22, Adrian Chadd wrote: >> Sweet, thanks. I'l test it, but anything that changes the locking to >> TCP is going to need a more thorough review. The "there be dragons" >> disclaimer is appropriate.:) >=20 > No changes in locking - simply some minor code reordering. This isn=E2=80=99t entirely true. You changed the INFO_WLOCK protocol, = and also drop the WLOCK to acquire the INFO_WLOCK in places, and it = isn=E2=80=99t clear to me at all why this is safe to do. Please document = the analysis you did to show that was safe. Warner