Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Jun 2013 23:23:05 -0700
From:      Jason Helfman <jgh@FreeBSD.org>
To:        Antoine Brodin <antoine@freebsd.org>
Cc:        "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r321445 - head/mail/gnarwl
Message-ID:  <CAMuy=%2Bj0FvdUx86RF9MX6-HBRXzvpwDtK8xuWkyG%2ByJxo3-VaA@mail.gmail.com>
In-Reply-To: <201306210619.r5L6JY12055282@svn.freebsd.org>
References:  <201306210619.r5L6JY12055282@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 20, 2013 at 11:19 PM, Antoine Brodin <antoine@freebsd.org>wrote:

> Author: antoine
> Date: Fri Jun 21 06:19:34 2013
> New Revision: 321445
> URL: http://svnweb.freebsd.org/changeset/ports/321445
>
> Log:
>   Make CONFIGURE_ARGS shorter and look better
>
>   Submitted by: danfe
>
> Modified:
>   head/mail/gnarwl/Makefile
>
> Modified: head/mail/gnarwl/Makefile
>
> ==============================================================================
> --- head/mail/gnarwl/Makefile   Fri Jun 21 06:17:24 2013        (r321444)
> +++ head/mail/gnarwl/Makefile   Fri Jun 21 06:19:34 2013        (r321445)
> @@ -18,7 +18,7 @@ USE_GMAKE=    yes
>  USES=          iconv
>  USE_OPENLDAP=  yes
>  GNU_CONFIGURE= yes
> -CONFIGURE_ARGS+=--with-docdir=${DOCSDIR}
> +CONFIGURE_ARGS=        --with-docdir=${DOCSDIR}
>
>  MAN8=          damnit.8 gnarwl.8
>  MANCOMPRESSED= yes
>
>
It may look more pretty, but in the end your original commit didn't clobber
any pre-existing CONFIGURE_ARGS that may have been set by the user. This
one does.

-jgh

--
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2Bj0FvdUx86RF9MX6-HBRXzvpwDtK8xuWkyG%2ByJxo3-VaA>