Date: Thu, 09 Feb 2006 19:11:39 +0500 From: Boris Kovalenko <boris@tagnet.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/93094: [MAINTAINER UPDATE] net/quagga: [SUMMARIZE CHANGES] Message-ID: <E1F7CWJ-000Fef-Kk@boris.nikom.ru> Resent-Message-ID: <200602091420.k19EK4Nh086574@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 93094
>Category: ports
>Synopsis: [MAINTAINER UPDATE] net/quagga: [SUMMARIZE CHANGES]
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Thu Feb 09 14:20:03 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Boris Kovalenko
>Release: FreeBSD 6.0-RELEASE i386
>Organization:
JSC TAGNet
>Environment:
System: FreeBSD boris.nikom.ru 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Mon Nov 7 11:38:40 YEKT
>Description:
[DESCRIBE CHANGES]
This update solves PR/93015
The correct (gcc-specific, non-C99 compliant) way to create a variable length structure would be to use:
unsigned char data[0];
Instead of:
unsigned char *data;
The above fix solves the vty crash. (Credits to Landon Fuller <landonf@opendarwin.org>)
Small fix to Makefile
TODO: Solve PR/93012
Added file(s):
- files/patch-ospfd-ospf_api.c
Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:
--- quagga-0.99.3_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net/quagga/Makefile /usr/ports/net/quagga.new/Makefile
--- /usr/ports/net/quagga/Makefile Wed Feb 8 10:17:43 2006
+++ /usr/ports/net/quagga.new/Makefile Wed Feb 8 11:58:57 2006
@@ -7,7 +7,7 @@
PORTNAME= quagga
PORTVERSION= 0.99.3
-PORTREVISION= 0
+PORTREVISION= 1
CATEGORIES= net ipv6
MASTER_SITES= http://quagga.net/download/
@@ -120,9 +120,9 @@
.if defined(WITH_SNMP) && !defined(WITHOUT_SNMP)
CONFIGURE_ARGS+=--enable-snmp
.if defined(WITH_SNMP_4)
-LIB_DEPENDS+=snmp.4:${PORTSDIR}/net-mgmt/net-snmp4:install
+LIB_DEPENDS+=snmp.4:${PORTSDIR}/net-mgmt/net-snmp4
.else
-LIB_DEPENDS+=netsnmp.9:${PORTSDIR}/net-mgmt/net-snmp:install
+LIB_DEPENDS+=netsnmp.9:${PORTSDIR}/net-mgmt/net-snmp
.endif
.endif
diff -ruN --exclude=CVS /usr/ports/net/quagga/files/patch-lib-buffer.c /usr/ports/net/quagga.new/files/patch-lib-buffer.c
--- /usr/ports/net/quagga/files/patch-lib-buffer.c Fri Feb 3 16:39:37 2006
+++ /usr/ports/net/quagga.new/files/patch-lib-buffer.c Wed Feb 8 11:47:06 2006
@@ -5,7 +5,7 @@
/* Actual data stream (variable length). */
- unsigned char data[]; /* real dimension is buffer->size */
-+ unsigned char *data; /* real dimension is buffer->size */
++ unsigned char data[0]; /* real dimension is buffer->size */
};
/* It should always be true that: 0 <= sp <= cp <= size */
diff -ruN --exclude=CVS /usr/ports/net/quagga/files/patch-ospfd-ospf_api.c /usr/ports/net/quagga.new/files/patch-ospfd-ospf_api.c
--- /usr/ports/net/quagga/files/patch-ospfd-ospf_api.c Thu Jan 1 05:00:00 1970
+++ /usr/ports/net/quagga.new/files/patch-ospfd-ospf_api.c Wed Feb 8 11:50:55 2006
@@ -0,0 +1,11 @@
+--- ospfd/ospf_api.c.orig Thu Nov 24 21:51:16 2005
++++ ospfd/ospf_api.c Wed Feb 8 11:49:31 2006
+@@ -68,7 +68,7 @@
+ struct opaque_lsa
+ {
+ struct lsa_header header;
+- u_char mydata[];
++ u_char mydata[0];
+ };
+
+ struct opaque_lsa *olsa;
--- quagga-0.99.3_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1F7CWJ-000Fef-Kk>