From owner-svn-src-all@freebsd.org Mon Nov 2 12:49:15 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F3B8A24D69; Mon, 2 Nov 2015 12:49:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1A17B1C9B; Mon, 2 Nov 2015 12:49:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tA2Cn9ld092772 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 2 Nov 2015 14:49:09 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tA2Cn9ld092772 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tA2Cn8bl092771; Mon, 2 Nov 2015 14:49:08 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 2 Nov 2015 14:49:08 +0200 From: Konstantin Belousov To: Michal Meloun Cc: Gleb Smirnoff , Alexey Dokuchaev , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r290234 - head/share/misc Message-ID: <20151102124908.GY2257@kib.kiev.ua> References: <201511011654.tA1GstJP054578@repo.freebsd.org> <20151102071346.GA12970@FreeBSD.org> <20151102103757.GE78469@FreeBSD.org> <56374D46.9040506@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56374D46.9040506@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 12:49:15 -0000 On Mon, Nov 02, 2015 at 12:47:18PM +0100, Michal Meloun wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Dne 02.11.2015 v 11:37 Gleb Smirnoff napsal(a): > > On Mon, Nov 02, 2015 at 07:13:46AM +0000, Alexey Dokuchaev wrote: > > A> On Sun, Nov 01, 2015 at 04:54:55PM +0000, Michal Meloun wrote: > > A> > New Revision: 290234 A> > URL: > > https://svnweb.freebsd.org/changeset/base/290234 A> > A> > Log: A> > > > Install myself as src committer. A> > A> > Approved by: kib > > (mentor) A> > > Description of fields to fill in above: > > 76 columns --| A> > [ garbage omitteed ] A> A> Here is a small > > advice: do not rely on "svn ci" calling your $EDITOR for A> you, > > compose the message yourself first and then do "svn ci -F > > $logfile". A> For one-liners, "svn ci -m message" works even > > better. > > > > Alternatively: rely on $EDITOR, but don't trust the line: > > > > --This line, and those below, will be ignored-- > > > > Finalize your message manually. > > > > P.S. Not that there is bugs in the svn, but you can have touched > > the line. > > > > I'm sorry to all, it?s my bug. > Commit using editor (but using git) is standard practice here @work. > So I automatically select same workflow for FreeBSD. > Anyway, I already got hit from kib@, so I'll use a file for commit log I hope you mean 'hint'. > next time. > > But i'm pretty sure that i have not touched template. > I only deleted all prepared unfilled lines (for PR:, MFC: ...) > and then i paste commit message. > And, ironically, only > > - --This line, and those below, will be ignored-- > > line has been omitted from real commit log. > > Michal > > > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQEcBAEBCAAGBQJWN01GAAoJEGkesmtexaqqGvEIAICYBFTeblZZ+C3Y82JqN97h > fnFHNG0wyJEhj9a4jDBWyAJldU4kesa2XHw2I8dGIUB9Iz+Vp0nnib5WIvhWPL7S > t1NdQDyy9MELAXx0v4wNnyDexl+YYM9nEGvQokesFV/V0vI+6WctjMM8S8tnRs1e > hVu80ZgbvJOTTV6OuNl9/Cjo4oPeh3IWZMlLuYP95pV4vzlgoF6CPimrdki8gVMX > dW/9DUIJd1bX73LYoCtwfM0WZEFFbbgrpBO8DJbSWEmx1hJUQmk5mYE8jUYDk9Ot > 8wxE+3n1g5ovZUQGREiR5s+3xu7MJ8PSroLIM69kJUvER0pAedXkDphYm/l8v8g= > =s8VI > -----END PGP SIGNATURE-----