From owner-freebsd-ports@FreeBSD.ORG Tue Jan 8 03:22:11 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8FB816A418; Tue, 8 Jan 2008 03:22:11 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 7304A13C457; Tue, 8 Jan 2008 03:22:07 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (unknown [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTP id 7028628481; Tue, 8 Jan 2008 11:22:03 +0800 (CST) Received: from localhost (unknown [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id CB734EB0AC2; Tue, 8 Jan 2008 11:22:02 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id dnZxxeLNca3n; Tue, 8 Jan 2008 11:21:58 +0800 (CST) Received: from charlie.delphij.net (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id D51A7EB08BD; Tue, 8 Jan 2008 11:21:55 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type; b=pLhXS5WEMg+Q8kkpdxPOf00hXdY8K7QHPa+RCyHZ3Yzghga6yWXbTcJhiXxsfNK2x Ik4/Wq+wf5CRNTdEu8Ung== Message-ID: <4782EC51.6020108@delphij.net> Date: Mon, 07 Jan 2008 19:21:53 -0800 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Scot Hetzel References: <790a9fff0801051224p4fb8481pbcc24051b2438dcf@mail.gmail.com> In-Reply-To: <790a9fff0801051224p4fb8481pbcc24051b2438dcf@mail.gmail.com> X-Enigmail-Version: 0.95.5 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: multipart/mixed; boundary="------------040209010407020403070705" Cc: ports@freebsd.org, sergei@freebsd.org, Xin LI Subject: Re: sysutils/cfengine: invalid use of USE_BDB X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2008 03:22:11 -0000 This is a multi-part message in MIME format. --------------040209010407020403070705 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Scot Hetzel wrote: > I have noticed that sysutils/cfengine is using USE_BDB incorrectly. > > USE_BDB?= 46 > > The USE_BDB variable is not a user setable variable. If someone were > to read this Makefile, they would get the wrong impression that they > should set USE_BDB in there /etc/make.conf, ports.conf, or > portupgrade.conf file. When they should instead be setting the > WITH_BDB_VER variable. > > The USE_BDB should be set to the minimum version of Berkeley DB that > the port will build with. > > USE_BDB= 44+ > > And left up to the person installing the port to specify a higher version. > > If you want to take the choice away from the installer and have the > port always use BDB 4.6, then the port should use: > > USE_BDB= 46 > > Which will prevent the use of BDB 4.4 and 4.5 from ever being used by this port. I think the proper use of *_BDB variables is that: WITH_BDB?= 46 (An advisory usage), and USE_BDB= yes as in the attachment. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHguxRi+vbBBjt66ARAuHIAKC5rRxKOvsAveDPEoAXbQvKxa4giACfQEpO EJk7hRJusCc6sWaTpLfiCoM= =yUim -----END PGP SIGNATURE----- --------------040209010407020403070705 Content-Type: text/plain; name="cfengine-bdb-usage.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cfengine-bdb-usage.diff" Index: Makefile =================================================================== RCS file: /home/ncvs/ports/sysutils/cfengine/Makefile,v retrieving revision 1.40 diff -u -p -r1.40 Makefile --- Makefile 4 Jan 2008 23:54:17 -0000 1.40 +++ Makefile 8 Jan 2008 03:16:59 -0000 @@ -16,7 +16,8 @@ COMMENT= A systems administration tool f USE_RC_SUBR= cfexecd cfservd -USE_BDB?= 46 +WITH_BDB_VER?= 46 +USE_BDB= yes USE_OPENSSL= yes GNU_CONFIGURE= yes CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL} --------------040209010407020403070705--