From owner-svn-src-all@freebsd.org Fri Mar 9 17:44:20 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9AD3FF3D0E4 for ; Fri, 9 Mar 2018 17:44:20 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1813F83302 for ; Fri, 9 Mar 2018 17:44:19 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 5d329c00-23c1-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 5d329c00-23c1-11e8-b951-f99fef315fd9; Fri, 09 Mar 2018 17:43:23 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w29HiBC8008208; Fri, 9 Mar 2018 10:44:11 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1520617451.84937.21.camel@freebsd.org> Subject: Re: svn commit: r330663 - head/sys/kern From: Ian Lepore To: Bruce Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 09 Mar 2018 10:44:11 -0700 In-Reply-To: <20180309194900.F2122@besplex.bde.org> References: <201803081704.w28H4aQx052056@repo.freebsd.org> <20180309150402.X950@besplex.bde.org> <20180309194900.F2122@besplex.bde.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 17:44:20 -0000 On Fri, 2018-03-09 at 20:50 +1100, Bruce Evans wrote: > style(9) does require this.  This is hard to see since the style > guide > has been mangled by converting it into a man page, with markup in non > C-code and lots of blank lines to separate the markup.  See > /usr/src/admin/style/style in 4.4BSD or /usr/src/share/misc/style in > NetBSD for non-mangled versions.  These are pure C code which give > many rules implicitly by example.  All versions give 2 or 3 rules for > leaving a blank line between groups of header files.  These rules are > somewhat needed since leaving blank lines is so unusual. I feel pretty certain that freebsd code does not have to conform to the style document in 4.4BSD, so I intend to waste absolutely none of my life reading it.  If you feel that the 4.4BSD rules about blank lines need to be part of freebsd's style(9), then submit patches to make it so, and we'll run it through the voting process like we do other style changes. -- Ian