Date: Mon, 18 Feb 2002 23:25:20 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Peter Wemm <peter@wemm.org>, current@FreeBSD.ORG Subject: Re: Patch sets to date and timing tests with Giant out of userret. Message-ID: <Pine.BSF.4.21.0202182322050.53728-100000@InterJet.elischer.org> In-Reply-To: <200202190646.g1J6kgE58769@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
The fully safe version of this code is: td->td_retval[0] = td->td_ucred->cr_ruid; td->td_retval[1] = td->td_ucred->cr_uid; return (0); because td->td_ucred is read-only for it's whole existance. Also, it's not worth arguing about this when Jouhn's not here.. and when he is it's better offline.. julian On Mon, 18 Feb 2002, Matthew Dillon wrote: > :> - mtx_lock(&Giant); > :> - td->td_retval[0] = p->p_ucred->cr_ruid; > :> + s = mtx_lock_giant(kern_giant_ucred); > :> + td->td_retval[0] = td->td_ucred->cr_ruid; > :> #if defined(COMPAT_43) || defined(COMPAT_SUNOS) > :> - td->td_retval[1] = p->p_ucred->cr_uid; > :> + td->td_retval[1] = td->td_ucred->cr_uid; > :> #endif > :> - mtx_unlock(&Giant); > :> + mtx_unlock_giant(s); > :> return (0); > : > :What a waste.. John has already done all this stuff already (using > :td_ucred instead of p_ucred) over the entire tree. > : > :Cheers, > :-Peter > > He didn't instrument Giant, and if you actually believe that one > massive commit is going to be more stable then the piecemeal safe-mode > commits I am making then you are smoking something. Or are you > expecting John to commit his patchset piecemeal as well and test > inbetween? If that is so, then he just wasted a whole lot time > managing all this junk in P4 because, frankly, it only took me a few > minutes to instrument the easier system calls. I spend far more > time testing. > > -Matt > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202182322050.53728-100000>